Page MenuHomePhabricator

Treat "request review" more like an update
ClosedPublic

Authored by epriestley on Mar 18 2014, 12:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 31, 10:08 AM
Unknown Object (File)
Sat, Aug 31, 3:51 AM
Unknown Object (File)
Mon, Aug 26, 10:34 PM
Unknown Object (File)
Sun, Aug 25, 7:05 PM
Unknown Object (File)
Sun, Aug 25, 10:48 AM
Unknown Object (File)
Mon, Aug 19, 11:12 AM
Unknown Object (File)
Aug 4 2024, 10:30 PM
Unknown Object (File)
Jul 30 2024, 1:51 PM

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP1e8ed3e5ffc7: Treat "request review" more like an update
Summary

After "reject; plan changes; request review", revisions go back to "needs revision". Instead, they should remain in "needs review" (the reviewers need to review comments on the "request review", in the normal case). Generally, "request reivew" should act a lot like "update", just not actually change the diff.

To accomplish this, downgrade reviewers on "request review" to "rejected older", just like we would on an update.

Test Plan

Did "reject; plan; request", revision ended in "needs review". Rejected it into "needs revision"; updated it into "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Treat "request review" more like an update.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: dctrwatson.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2014, 12:22 AM
epriestley updated this revision to Diff 20312.

Closed by commit rP1e8ed3e5ffc7 (authored by @epriestley).