Page MenuHomePhabricator

Fix two registration errors for unusual provider emails
ClosedPublic

Authored by epriestley on Mar 14 2014, 1:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 5:10 AM
Unknown Object (File)
Tue, Apr 30, 12:10 AM
Unknown Object (File)
Mon, Apr 29, 9:41 PM
Unknown Object (File)
Mon, Apr 29, 9:41 PM
Unknown Object (File)
Mon, Apr 29, 3:56 PM
Unknown Object (File)
Sat, Apr 27, 1:55 AM
Unknown Object (File)
Wed, Apr 24, 10:29 PM
Unknown Object (File)
Sat, Apr 20, 12:16 PM
Tokens
"Like" token, awarded by jucrouzet.

Details

Summary

See https://github.com/facebook/phabricator/issues/541.

  • If a provider returns the email "" or "0", we currently don't let the user edit it and thus don't let them register.
  • If a provider returns an invalid email like "!!!" (permitted by GitHub, e.g.), we show them a nonsense error message.

Instead:

  • Pretend we didn't get an address if we get an invalid address.
  • Test the address strictly against null.
Test Plan

Registered on Phabricator with my GitHub email set to "" (empty string) and "!!!" (bang bang bang).

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix two registration errors for unusual provider emails.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Mar 14 2014, 2:00 AM
epriestley updated this revision to Diff 20235.

Closed by commit rPf7b1ed722164 (authored by @epriestley).