Page MenuHomePhabricator

Add "pusher is committer" to Herald as a pre-commit rule
ClosedPublic

Authored by epriestley on Mar 12 2014, 9:35 PM.
Tags
None
Referenced Files
F15430135: D8507.diff
Mon, Mar 24, 6:10 AM
F15399430: D8507.id.diff
Mon, Mar 17, 4:31 AM
F15383300: D8507.diff
Fri, Mar 14, 4:09 PM
F15381559: D8507.id20186.diff
Fri, Mar 14, 8:20 AM
F15381321: D8507.id20186.diff
Fri, Mar 14, 7:04 AM
F15354678: D8507.diff
Tue, Mar 11, 5:19 AM
F15354664: D8507.id20183.diff
Tue, Mar 11, 5:18 AM
Unknown Object (File)
Feb 21 2025, 3:32 AM
Subscribers

Details

Summary

Fixes T4594. Also, allow "exists" / "does not exist" to be run against author/committer. This allows construction of rules like:

  • Committer identities must be authentic.
  • Committer identities must be resolvable.
  • Author identities must be resolvable.
Test Plan

Created some rules using these new rules and ran them.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Add "pusher is committer" to Herald as a pre-commit rule.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2014, 9:49 PM
epriestley updated this revision to Diff 20186.

Closed by commit rP193e8a54fc20 (authored by @epriestley).