Page MenuHomePhabricator

Fix two transactional issues around revision status
ClosedPublic

Authored by epriestley on Mar 12 2014, 8:44 PM.

Details

Summary

Two issues:

  • Herald is currently overwriting accepts and rejects with "blocking reviewer". Just stop it from doing that.
  • When you update an accepted revision, we put it back in "needs review", then return it to "accepted", generating an extra transaction. Instead, don't.
Test Plan
  • Updated a revision with an accepting, herald-based blocking project reviewer. Reviewer was still accepting.
  • Updated an accepted revision, didn't get an extra transaction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix two transactional issues around revision status.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2014, 9:49 PM
epriestley updated this revision to Diff 20187.

Closed by commit rP3b861ab7411d (authored by @epriestley).