Page MenuHomePhabricator

Remove `phpast.*` Conduit methods
ClosedPublic

Authored by epriestley on Mar 12 2014, 3:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 9:32 AM
Unknown Object (File)
Fri, May 3, 9:32 AM
Unknown Object (File)
Fri, May 3, 1:59 AM
Unknown Object (File)
Wed, May 1, 2:30 PM
Unknown Object (File)
Sat, Apr 27, 9:36 PM
Unknown Object (File)
Tue, Apr 23, 3:36 PM
Unknown Object (File)
Wed, Apr 10, 8:27 AM
Unknown Object (File)
Wed, Apr 10, 7:37 AM
Subscribers

Details

Summary

Ref T4592. These were added with the intent of not requiring builds on Windows, but then we got builds on Windows working and they seem to be straightforward. See T4592 for most recent discussion.

Remove these methods because they aren't really practical for anything and increase attack surface area by giving adversaries access to xhpast, and generally bloat up the Conduit API. To my knowledge, nothing has ever called them.

(If an install somehow relies on these, they can drop them into src/extensions/ to expose them again.)

Test Plan

Viewed conduit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove `phpast.*` Conduit methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2014, 4:16 PM
epriestley updated this revision to Diff 20176.

Closed by commit rP69399dfc2ad2 (authored by @epriestley).