Default new reviewers to "added", and don't overwrite reviewer states when updating
ClosedPublic
Actions

Authored by epriestley on Mar 11 2014, 11:36 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP0b6c0c135f84: Default new reviewers to "added", and don't overwrite reviewer states when…

Summary

Fixes two issues with Differential:

New reviewers on initial diff were being created into a null state.
The "=" edge update was overwriting accepted/rejected statuses. This could maybe be more nuanced in the long run, but I've just made it update correctly for now.

Test Plan

Created and updated a revision, paying attention to reviewer statuses.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20155.Mar 11 2014, 11:36 PM

epriestley retitled this revision from to Default new reviewers to "added", and don't overwrite reviewer states when updating.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added subscribers: epriestley, aran.Mar 11 2014, 11:36 PM

btrahan accepted this revision.Mar 11 2014, 11:42 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 11 2014, 11:42 PM

Closed by commit rP0b6c0c135f84 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialReviewersField.php

14 lines

Diff 20158

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Default new reviewers to "added", and don't overwrite reviewer states when updatingClosedPublicActions