Page MenuHomePhabricator

Don't prefill "add email address" from GET
ClosedPublic

Authored by epriestley on Mar 8 2014, 8:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 9 2026, 11:49 PM
Unknown Object (File)
Mar 8 2026, 9:27 AM
Unknown Object (File)
Mar 5 2026, 9:25 PM
Unknown Object (File)
Feb 17 2026, 5:13 PM
Unknown Object (File)
Feb 13 2026, 12:00 PM
Unknown Object (File)
Feb 3 2026, 7:51 AM
Unknown Object (File)
Feb 3 2026, 6:56 AM
Unknown Object (File)
Jan 16 2026, 5:13 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP761b66228371: Don't prefill "add email address" from GET
Summary

Via HackerOne. I don't think this is a security vulnerability, but it is inconsistent. There's no reason to prefill this, and I think the code was just lazy.

Test Plan
  • Hit this page with ?email=xyz in a GET request, no more prefill.
  • Looped the page with bad addresses, appropriate prefill.
  • Added an address.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 4:58 PM
epriestley updated this revision to Diff 20105.

Closed by commit rP761b66228371 (authored by @epriestley).