Ref T4556. Show a notification if the window isn't at 100%.
Details
Details
- Reviewers
btrahan chad - Maniphest Tasks
- T4556: Fix application button linebreaking at 90% zoom level in Chrome
{F122609}
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- detectzoom
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
Comment Actions
This isn't great. Some limitations:
- It works in Chrome and Safari, but not Firefox (this is very hard on Firefox), and probably not IE. However, we currently get 100% of zoom reports about Chrome. In browsers where it doesn't work it doesn't do anything bad, it just doesn't do anything.
- It doesn't react to the user zooming the page; it only fires once on page load. This seems fine, but the most beautiful implementation of this possible would be more dynamic.
- If any users actually use zoom intentionally, this will annoy them, and I don't have a great fix. We've only ever seen one user who zooms intentionally, I think. But if we land this, I think there's a good chance that we'll get more.
I'm pretty noncommittal about this in general, but if this seems reasonable we can give it a shot.
Comment Actions
If this is only really the app-icons, it was something I was fiddling with fixing with my nav update. Overall, I'm fine with some one-time, closable notification, but don't want to force people to not zoom.
Comment Actions
Yeah -- 95% of the value of this to me is stopping these reports, and I think a one-time notification probably won't have much effect (the user will zoom by accident, get the notification, then zoom by accident again a few months later and report an issue). I don't think this is worth adding any code to track whether users have seen the notification or not, and I definitely don't want to add a preference for it.
Fixing the icons instead seems reasonable to me. Users who accidentally zoom will still suffer a degraded experience (a lot of stuff looks weird at 90%), but if they can't tell then I guess that's fine.
(If we eventually implement something like T302 (e.g., a streamlined "Report a Bug" workflow in the software), we could put this kind of detection there to resolve the report issue, maybe.)