Page MenuHomePhabricator

Add phutil_json_decode(), for convenience
ClosedPublic

Authored by epriestley on Feb 27 2014, 8:30 PM.
Tags
None
Referenced Files
F19823224: D8363.diff
Sat, Mar 7, 10:49 AM
F19818866: D8363.id19886.diff
Fri, Mar 6, 12:51 AM
F19554387: D8363.id19886.diff
Jan 29 2026, 9:22 PM
F19549556: D8363.id19886.diff
Jan 27 2026, 10:41 AM
F19533883: D8363.id.diff
Jan 20 2026, 8:59 PM
F19531392: D8363.id19881.diff
Jan 20 2026, 4:31 AM
F19528135: D8363.diff
Jan 19 2026, 6:59 AM
F19526569: D8363.diff
Jan 18 2026, 6:05 PM
Subscribers

Details

Summary

This is just a convenience method for decoding possibly-sketchy strings. We have a lot of cases where we may try to decode some uninitialized value (like null) and then check if we got something sensible out or not.

Particularly, almost all of these can likely be simplified:

$ git grep -A1 -i 'json_decode' . | grep is_array | wc -l
33
Test Plan

Added and executed unit tests.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 27 2014, 10:08 PM