Use Array.prototype.slice in JX.$A
ClosedPublic
Actions

Authored by cpojer on Aug 18 2011, 9:22 PM.

Tags

None

Referenced Files

	F13151075: D835.diff
	Sat, May 4, 6:19 PM

	Unknown Object (File)
	Wed, Apr 24, 10:00 PM

	Unknown Object (File)
	Sun, Apr 21, 3:51 PM

	Unknown Object (File)
	Thu, Apr 11, 8:38 AM

	Unknown Object (File)
	Wed, Apr 10, 7:37 AM

	Unknown Object (File)
	Apr 1 2024, 9:38 AM

	Unknown Object (File)
	Mar 23 2024, 5:13 AM

	Unknown Object (File)
	Mar 10 2024, 7:05 PM

Subscribers

Details

Reviewers

tomo
mroch
epriestley

Commits

Restricted Diffusion Commit
rPf36d504b7573: Use Array.prototype.slice in JX.$A

Summary

Being bold. I think it is fine to do this in 2011.

Test Plan

Run the new specs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

I'll accept this when Microsoft ends IE7 support (in April 2014?).

Push it back to me in 2014.

Only 7 months left, is everyone excited?

{C125}

itsawesome

There is nothing that I wanted more in all this time…

This is happening this year!

HEY!

HEY!!!

THIS IS HAPPENING TODAY

I cannot deny that the number of bytes saved through this diff generate an incredible amount of satisfaction to me. Support Impact

minioncheer

chad added a subscriber: chad.Mar 31 2014, 6:15 PM

(I'm pulling a mutant version of this.)

This revision is now accepted and ready to land.Apr 3 2014, 4:44 PM

Closed by commit rPf36d504b7573 (authored by @epriestley).

epriestley edited edge metadata.Apr 3 2014, 4:45 PM

epriestley changed the visibility from "All Users" to "Public (No Login Required)".

@epriestley can you restart the timer for 2020?

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

externals/

javelin/

core/

util.js

11 lines

Diff 20609

View Options

webroot/rsrc/externals/javelin/core/util.js

Use Array.prototype.slice in JX.$AClosedPublicActions