Page MenuHomePhabricator

Reuse common getUser() / setUser() in PHUICalendarListView
ClosedPublic

Authored by epriestley on Feb 25 2014, 2:29 AM.
Tags
None
Referenced Files
F15382707: D8329.diff
Fri, Mar 14, 2:01 PM
F15345753: D8329.id19809.diff
Mon, Mar 10, 12:18 PM
F15302894: D8329.id19808.diff
Wed, Mar 5, 11:29 PM
Unknown Object (File)
Mon, Feb 24, 11:32 AM
Unknown Object (File)
Mon, Feb 17, 11:48 AM
Unknown Object (File)
Mon, Feb 17, 10:44 AM
Unknown Object (File)
Mon, Feb 17, 10:44 AM
Unknown Object (File)
Sun, Feb 16, 12:25 AM
Subscribers

Details

Summary

These methods already exist in AphrontView. The redefinition can sometimes cause this warning:

[2014-02-24 18:27:48] ERROR 2048: Declaration of PHUICalendarListView::setUser() should be compatible with AphrontView::setUser(PhabricatorUser $user) at [/INSECURE/devtools/phabricator/src/view/phui/calendar/PHUICalendarListView.php:138]
Test Plan

Viewed calendar on profile.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped