Page MenuHomePhabricator

Add AWS Region support to PhutilAWSFuture.
ClosedPublic

Authored by seporaitis on Feb 23 2014, 8:05 PM.
Tags
None
Referenced Files
F15506237: D8311.id19775.diff
Tue, Apr 15, 9:41 AM
F15503429: D8311.id.diff
Mon, Apr 14, 9:56 AM
F15495576: D8311.diff
Sun, Apr 13, 5:03 AM
F15452810: D8311.id19762.diff
Sat, Mar 29, 7:26 AM
F15415556: D8311.id19762.diff
Mar 20 2025, 6:38 AM
F15398818: D8311.id19775.diff
Mar 17 2025, 1:49 AM
F15332953: D8311.diff
Mar 7 2025, 10:37 PM
F15301157: D8311.diff
Mar 5 2025, 5:30 PM

Details

Summary

Almost all AWS services endpoints follow this structure: SERVICE_NAME.REGION_ID.amazonaws.com. This revision adds support for setting a region in PhutilAWSFuture.

There are couple of exceptions to above rule - some services do not have region in their endpoint url (DevPay, Route 53, IAM, Import/Export, Security Token Service), some have a single endpoint in one region (OpsWorks, Support), some are funky (S3), but they all can be covered by overriding getHost() method.

Test Plan

No tests added. I acked through three repositories (libphutil, arcanist & phabricator) and couldn't find AWS used anywhere.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I think this is only used in some Drydock code that's sitting half-finished somewhere.