Page MenuHomePhabricator

Load and attach objects when loading application transactions
ClosedPublic

Authored by epriestley on Feb 18 2014, 11:58 PM.
Tags
None
Referenced Files
F14027167: D8273.diff
Fri, Nov 8, 5:46 AM
F13986517: D8273.diff
Mon, Oct 21, 3:36 AM
F13981937: D8273.id.diff
Sat, Oct 19, 8:03 PM
F13964500: D8273.id19686.diff
Tue, Oct 15, 8:45 PM
Unknown Object (File)
Sun, Oct 13, 1:47 AM
Unknown Object (File)
Oct 7 2024, 12:46 PM
Unknown Object (File)
Sep 25 2024, 9:02 AM
Unknown Object (File)
Sep 21 2024, 11:38 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP3103ce33b82d: Load and attach objects when loading application transactions
Summary

Ref T3886. Fixes the removed TODO. This also implements the generally reasonable policy "you have to be able to see an object in order to see its transactions". That was implicit before (we never load transactions without loading an object first) but is now explicit.

This fixes bad (nonspecialized) rendering of custom field transactions in Projects, and shortly in Differential, where stories would read "alincoln edited this object." instead of a more specific string.

Test Plan

Viewed a project edit, saw a more specific string. Browed ApplicationTransaction applications.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped