Page MenuHomePhabricator
Differential D8265

Add crumbs to calendar
ClosedPublic
Actions

Authored by chad on Feb 17 2014, 10:03 PM.
Tags
None
Referenced Files
F15569483: D8265.id19657.diff
Sun, May 4, 12:34 AM
F15560741: D8265.id19655.diff
Tue, Apr 29, 4:21 PM
F15538523: D8265.id19672.diff
Thu, Apr 24, 7:48 PM
F15531196: D8265.id19672.diff
Wed, Apr 23, 10:10 AM
F15525934: D8265.id19657.diff
Mon, Apr 21, 5:57 PM
F15506089: D8265.id19657.diff
Tue, Apr 15, 8:35 AM
F15504117: D8265.id.diff
Mon, Apr 14, 3:58 PM
F15502644: D8265.id.diff
Mon, Apr 14, 2:46 AM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T4440: Add Crumbs to Calendar
Commits
Restricted Diffusion Commit
rP2eeef339bf01: Add crumbs to calendar
Summary

Crumbs everywhere. Not sure how to better format the date, let me know.

Test Plan

Browse everything I can see in Calendar

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.Feb 17 2014, 10:50 PM
src/applications/calendar/controller/PhabricatorCalendarBrowseController.php
61

maybe just kill this since it is written just below? otherwise I would expect it to have the same formatting as the calendar top bar does

chad added a comment.Feb 17 2014, 10:54 PM

We duplicate page names usually, and this will eventually transition into a year > month > week view.

chad updated this revision to Unknown Object (????).Feb 17 2014, 11:06 PM
  • Fix datetime
epriestley accepted this revision.Feb 17 2014, 11:53 PM

We can keep smoothing this out as we develop the feature set.

chad closed this revision.Feb 18 2014, 12:08 AM

Closed by commit rP2eeef339bf01 (authored by @chad).

Revision Contents
Changeset List

Diff 19672

View Options

src/applications/calendar/controller/PhabricatorCalendarBrowseController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventListController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility