Page MenuHomePhabricator

Mail icon for email lists in typeahead
ClosedPublic

Authored by chad on Feb 17 2014, 5:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 12:05 AM
Unknown Object (File)
Sun, Apr 28, 12:05 AM
Unknown Object (File)
Thu, Apr 11, 7:10 AM
Unknown Object (File)
Apr 7 2024, 5:53 AM
Unknown Object (File)
Apr 6 2024, 10:47 AM
Unknown Object (File)
Mar 30 2024, 6:57 PM
Unknown Object (File)
Mar 5 2024, 12:01 AM
Unknown Object (File)
Feb 20 2024, 6:51 PM

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPda459fd536b2: Mail icon for email lists in typeahead
Summary

Adds a mail icon to use in the typeahead

Also, can we add a special class per obj-type? (May want to special color projects, etc) Will try to live without them.

Test Plan

photoshop

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Unknown Object (????).Feb 17 2014, 5:52 PM
  • ImageOptim

I installed ImageOptim and re-generated all sprites, since I think I was making them poorly before.

Also, can we add a special class per obj-type? (May want to special color projects, etc) Will try to live without them.

Yeah, I definitely want to do this -- e.g. "tag", "briefcase", "group of people" for Projects, and give colors a shot (I think they'll be really useful if we can get them looking nice). The code supports it, I mostly need to write the edit UI in projects. Coming soon!

Do we have more metadata we can show on image changes? We round the data on Files so I couldn’t tell in Differential what the file size changes were.

chad updated this revision to Unknown Object (????).Feb 17 2014, 6:06 PM
  • Celery

We have the data, it just stalled out a while ago (D5206) because I didn't want to put it in a totally separate table. It should be easy to fix the minor UI issues with that diff.