Page MenuHomePhabricator

Improve tokenizer loading behaviors
ClosedPublic

Authored by epriestley on Feb 14 2014, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 11 2024, 11:41 AM
Unknown Object (File)
Feb 6 2024, 4:01 PM
Unknown Object (File)
Feb 4 2024, 2:59 AM
Unknown Object (File)
Jan 24 2024, 2:26 PM
Unknown Object (File)
Jan 24 2024, 2:25 PM
Unknown Object (File)
Jan 24 2024, 9:45 AM
Unknown Object (File)
Jan 24 2024, 9:45 AM
Unknown Object (File)
Dec 4 2023, 7:23 PM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rP0efce646c95f: Improve tokenizer loading behaviors
Summary

Ref T4420. Fixes T3309. Two major UX issues here:

  • When the user extends a query ("alin" -> "alinc"), we currently hide all the results, then show them again when the new results arrive. This makes the typeahead feel a bit flickery. Instead, show matching results, then add more results when everything arrives.
  • When loading more results from ondemand sources, we currently do not give you any indication that things are loading. Instead:
    • Show a loading GIF (this might need Design help, @chad).
    • Slightly lighten the control border.
    • I didn't want to do anything like actually add "loading" text because it would cause UI flicker in the 'extend a query' case and some other cases, but otherwise this design is totally made up.
Test Plan

Typed into tokenizers and extended queries, got a better-feeling UI.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
208

whoops

epriestley updated this revision to Unknown Object (????).Feb 14 2014, 4:42 PM
  • Remove debugigng JX.log() call.

I actually wonder if we could get away with just the border color change. I could delete a decent amount of this code if we didn't need the loading GIF. The border color is pretty subtle and it's not necessarily obvious what it means, but it looks good to me visually and users generally haven't complained about this in the past, it's always just seemed a little rough to me to not have an indicator.

play with it like this for a few days / hours and see what we think?

Sounds good. This is live now, let me know how it feels.