Page MenuHomePhabricator

Begin modularizing typeahead sources
ClosedPublic

Authored by epriestley on Feb 14 2014, 3:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 6:25 PM
Unknown Object (File)
Tue, Apr 16, 1:45 AM
Unknown Object (File)
Tue, Apr 9, 10:01 AM
Unknown Object (File)
Fri, Apr 5, 3:17 PM
Unknown Object (File)
Wed, Apr 3, 5:26 PM
Unknown Object (File)
Tue, Apr 2, 4:45 AM
Unknown Object (File)
Fri, Mar 29, 6:35 AM
Unknown Object (File)
Feb 4 2024, 2:59 AM
Subscribers

Details

Summary

Ref T4420. This sets up the basics for modular typeahead sources. Basically, the huge switch() is just replaced with class-based runtime dispatch.

The only clever bit I'm doing here is with CompositeDatasource, which pretty much just combines the results from several other datasources. We can use this to implement some of the weird cases where we need multiple types of results, although I think I can entirely eliminate many of them entirely. It also makes top-level implementation simpler, since more logic can go inside the sources.

Sources are also application-aware, will be responsible for placeholder text, and have a slightly nicer debug view.

Test Plan

{F112859}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped