Page MenuHomePhabricator

Use pixel as background of timeline
ClosedPublic

Authored by chad on Feb 13 2014, 11:06 PM.
Tags
None
Referenced Files
F13229061: D8221.diff
Mon, May 20, 2:06 PM
F13182578: D8221.diff
Thu, May 9, 11:48 PM
Unknown Object (File)
Mon, May 6, 12:19 PM
Unknown Object (File)
Mon, May 6, 6:02 AM
Unknown Object (File)
Thu, May 2, 8:07 PM
Unknown Object (File)
Sun, Apr 28, 4:20 AM
Unknown Object (File)
Sun, Apr 28, 4:20 AM
Unknown Object (File)
Sun, Apr 28, 4:20 AM

Details

Summary

Makes the line in timeline a background "image" instead.

Test Plan

Tested Desktop, Mobile, and Tablet breakpoints with lots of content.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Consider just using the image with a normal URL, and we'll do the data URL thing automatically under some threshold (T3300). We already parse and rewrite the URL and could easily rewrite it into a data URL.

chad updated this revision to Unknown Object (????).Feb 13 2014, 11:15 PM
  • Add back the image