Diffusion - fix browse file bug
ClosedPublic
Actions

Authored by btrahan on Feb 11 2014, 4:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 8:03 AM

	Unknown Object (File)
	Fri, Dec 13, 5:49 AM

	Unknown Object (File)
	Mon, Dec 9, 12:33 AM

	Unknown Object (File)
	Sun, Dec 8, 8:01 PM

	Unknown Object (File)
	Fri, Dec 6, 11:59 AM

	Unknown Object (File)
	Fri, Dec 6, 5:18 AM

	Unknown Object (File)
	Thu, Dec 5, 12:37 AM

	Unknown Object (File)
	Sun, Dec 1, 9:02 AM

Subscribers

Details

Reviewers

epriestley

Maniphest Tasks

T4402: "Skip Past This Commit" returns fatal error calling getCommitIdentifier() on a non-object

Commits

Restricted Diffusion Commit
rP8739ea4dc103: Diffusion - fix browse file bug

Summary

we were calling a member method on a diffusion hash. not sure why. Fixes T4402

Test Plan

clicked about, no fatals and seemed to move sensical backwards in time

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Oh, I think diffusion.commitparentsquery previously had some magic which wouldn't have survived real calls over the wire. D7808 fixed that to make it return identifiers instead, but I missed this callsite. Thanks!

Closed by commit rP8739ea4dc103 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseFileController.php

2 lines

Diff 18543

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Diffusion - fix browse file bugClosedPublicActions