Page MenuHomePhabricator

Allow unsubscription from projects
ClosedPublic

Authored by epriestley on Feb 10 2014, 11:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 9 2025, 2:25 PM
Unknown Object (File)
May 8 2025, 10:12 AM
Unknown Object (File)
May 8 2025, 3:04 AM
Unknown Object (File)
May 7 2025, 10:54 AM
Unknown Object (File)
May 5 2025, 6:05 AM
Unknown Object (File)
May 5 2025, 6:05 AM
Unknown Object (File)
May 5 2025, 6:05 AM
Unknown Object (File)
May 5 2025, 6:05 AM
Subscribers

Details

Summary

Fixes T4379. Several changes:

  • Migrate all project members into subscribers.
  • When members are added or removed, subscribe or unsubscribe them.
  • Show sub/unsub in the UI.
  • Determine mailable membership of projects by querying subscribers.
Test Plan
  • As duck, joined a project.
  • Added the project as a reviewer to a revision.
  • Commented on the revision.
  • Observed duck receive mail.
  • Unsubscribed as duck.
  • Observed no mail.
  • Resubscribed as duck.
  • Mail again.
  • Joined/left project, checked sub/unsub status.
  • Ran migration, looked at database.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline