Page MenuHomePhabricator

Allow unsubscription from projects
ClosedPublic

Authored by epriestley on Feb 10 2014, 11:25 PM.
Tags
None
Referenced Files
F14810067: D8189.id18540.diff
Sun, Jan 26, 9:51 PM
Unknown Object (File)
Sat, Jan 25, 1:37 PM
Unknown Object (File)
Tue, Jan 21, 9:01 AM
Unknown Object (File)
Fri, Jan 17, 8:25 AM
Unknown Object (File)
Thu, Jan 16, 2:07 AM
Unknown Object (File)
Dec 10 2024, 8:33 PM
Unknown Object (File)
Nov 26 2024, 11:22 PM
Unknown Object (File)
Nov 26 2024, 3:55 PM
Subscribers

Details

Summary

Fixes T4379. Several changes:

  • Migrate all project members into subscribers.
  • When members are added or removed, subscribe or unsubscribe them.
  • Show sub/unsub in the UI.
  • Determine mailable membership of projects by querying subscribers.
Test Plan
  • As duck, joined a project.
  • Added the project as a reviewer to a revision.
  • Commented on the revision.
  • Observed duck receive mail.
  • Unsubscribed as duck.
  • Observed no mail.
  • Resubscribed as duck.
  • Mail again.
  • Joined/left project, checked sub/unsub status.
  • Ran migration, looked at database.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline