Migrate project profiles onto projects, and remove ProjectProfile object
ClosedPublic
Actions

Authored by epriestley on Feb 10 2014, 8:37 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4379: Audits in Small Teams setup has started sending emails to everyone in project on concern raised

Commits

Restricted Diffusion Commit
rP8c84ed61b1e6: Migrate project profiles onto projects, and remove ProjectProfile object

Summary

Ref T4379. Long ago, the "Project" vs "ProjectProfile" split was intended to allow a bunch of special fields on projects without burdening the simple use cases, but CustomField handles that far better and far more generally, and doing this makes using ApplicationTransactions a pain to get right, so get rid of it.

The only remaining field is profileImagePHID, which we can just move to the main Project object. This is custom enough that I think it's reasonable not to express it as a custom field.

Test Plan

Created a project, set profile, edited project, viewed in typeahead, ran migration, verified database results.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

are you going to drop the project_profile table in a future diff?

Yeah -- I'm probably going to do the [Later] ... thing just so we aren't outright destroying data in case the migrations are bogus, but this table is pretty low risk. If it didn't have the descriptions in it I'd just drop it outright.