Adds a handy bar full of tiny buttons. Use only when directed. Ref: T4394
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T4394: Build PHUIButtonBar and icons
- Commits
- Restricted Diffusion Commit
rP724be3930f3f: PHUIButtonBarView
View UI Examples.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Use only when directed.
NO! Soon everything will be a button!
| src/view/phui/PHUIButtonBarView.php | ||
|---|---|---|
| 6 | Consider buttons instead of button. | |
| 27–33 | With just one button, this will put -first -- but not -last -- on the button. It looks like a button with both styles wouldn't quite work anyway. Not sure if we care about this. | |
Comment Actions
I'll update to support just one button.
Also - unable to pull again from secure, getting ssh errors just like Friday night
Comment Actions
I can't repro the SSH stuff. Do you remember what the error you had with arc diff around the same time was that you mentioned? That shouldn't use SSH, so it might help us narrow down the issue.
Comment Actions
family:phabricator familyroom$ arc land --trace
libphutil loaded from '/Users/familyroom/Sites/libphutil/src'.
arcanist loaded from '/Users/familyroom/Sites/arcanist/src'.
Working Copy: Reading .arcconfig from "/Users/familyroom/Sites/phabricator/.arcconfig".
Working Copy: Path "/Users/familyroom/Sites/phabricator" is part of `git` working copy "/Users/familyroom/Sites/phabricator".
Working Copy: Project root is at "/Users/familyroom/Sites/phabricator".
Loading phutil library from '/Users/familyroom/Sites/phabricator/src'...
>>> [0] <conduit> conduit.connect() <bytes = 459>
>>> [1] <http> https://secure.phabricator.com/api/conduit.connect
<<< [1] <http> 12,974 us
<<< [0] <conduit> 13,174 us
[2014-02-09 17:57:17] EXCEPTION: (HTTPFutureResponseStatusCURL) [cURL/7] (https://secure.phabricator.com/api/conduit.connect) <CURLE_COULDNT_CONNECT> The cURL library raised an error while making a request. You may be able to find more information about this error (error code: 7) on the cURL site: http://curl.haxx.se/libcurl/c/libcurl-errors.html#CURLECOULDNTCONNECT at [/Users/familyroom/Sites/libphutil/src/future/http/HTTPSFuture.php:362]
#0 HTTPSFuture::isReady() called at [/Users/familyroom/Sites/libphutil/src/future/Future.php:40]
#1 Future::resolve(null) called at [/Users/familyroom/Sites/libphutil/src/future/FutureProxy.php:37]
#2 FutureProxy::resolve() called at [/Users/familyroom/Sites/libphutil/src/conduit/ConduitClient.php:26]
#3 ConduitClient::callMethodSynchronous(conduit.connect, Array of size 6 starting with: { client => arc }) called at [/Users/familyroom/Sites/arcanist/src/workflow/ArcanistBaseWorkflow.php:344]
#4 ArcanistBaseWorkflow::authenticateConduit() called at [/Users/familyroom/Sites/arcanist/scripts/arcanist.php:286]Comment Actions
This looks pretty similar, especially if you're on Mavericks:
https://discussions.apple.com/thread/5551686
Does rebooting fix it?
Comment Actions
Rebooting fixes it, I had tons of connections on netstat. Not sure if it's the same problem or not, but very suspicious.
Comment Actions
The sad thing is I have network issues on both Mac Mini's now. I've set them up to reboot every Monday morning, should tide me over until it gets sorted in 6 months.