Page MenuHomePhabricator

Improve detection of no-op edge edits in ApplicationTransactions
ClosedPublic

Authored by epriestley on Feb 7 2014, 8:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 11:16 AM
Unknown Object (File)
Thu, Dec 5, 10:01 AM
Unknown Object (File)
Thu, Dec 5, 7:49 AM
Unknown Object (File)
Thu, Dec 5, 7:49 AM
Unknown Object (File)
Nov 26 2024, 11:14 PM
Unknown Object (File)
Nov 26 2024, 3:53 PM
Unknown Object (File)
Nov 22 2024, 9:21 PM
Unknown Object (File)
Nov 18 2024, 10:34 AM
Subscribers

Details

Summary

Ref T4379. When you add a redundant edge, we currently compare the values strictly, using ===. However, the old and new versions of the edge have slightly different member data, because one has been synthetically constructed and one has been read from the database.

Instead, compare only the things we actually care about:

  1. Were any destintations added or removed?
  2. Was any edge data changed?

If the answer to both questions is "no", consider the update a no-op.

Test Plan

In the next diff, I'm making project members use the EDGE transaction type. Before this change, adding an existing project member would generate a transaction with no changes. Now, it is correctly detected as a no-op, while normal transactions continue to work properly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped