Been running this for over a week now on a multi-hundred user installation and it looks solid.

This commit broke our phabricator instance, we are unable to authenticate, or visit the Auth Proviers page. We are able to visit auth/config/edit/1/ directly.

My config prior to his update is as follows.
Allow Registration: True
Allow Linking Accounts: False
Allow Unlinking Accounts: False
ldap hostname: cs.wwu.edu
ldap port: 389
Base Distinguished Name: DC=cs,DC=wwu,DC=edu
Search Attribute: sAMAccountName
Username Attribute: <BLANK>
Realname Attribute: givenName, sn
LDAP Version: 3
Enable Referals: False
Use TLS: False
Search First: False
Anonymous Username: <BLANK>
Anonymous Password: <BLANK>
Active Directory Domain: cs.wwu.edu

What happens when you attempt to authenticate?
What happens when you attempt to visit /auth/?

/auth/ and /login/ return the following

UNRECOVERABLE FATAL ERROR <<<

Call to undefined method PhutilAuthAdapterLDAP::setSearchAttributes()

/usr/local/www/phabricator/src/applications/auth/provider/PhabricatorAuthProviderLDAP.php:44

┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

If I am authenticated as an admin on revision 7167a72 and then checkout revision ba8925a, while I can't authenticate or login, I can edit the config at auth/config/edit/1/, setting an anonymous username and password, as well as entering sAMAccountName for username attribute, does not solve the probelm.

Oh, maybe you didn't upgrade libphutil/ at the same time up upgraded phabricator/? You should keep the three libraries (libphutil, arcanist and phabricator) in sync and pull them all at the same time. That method was added in D8159, immediately before this change.

(If you did update, you might need to restart apache or php-fpm, since they may have a cached version of the old code in APC.)

DOH. That was the problem. I will make sure that is in our list of tasks for our admins. Thank you very much you rock.

Awesome! Let us know if you run into anything else.