Page MenuHomePhabricator

Herald - add support for task priority
ClosedPublic

Authored by btrahan on Feb 6 2014, 7:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 1:41 PM
Unknown Object (File)
Wed, Nov 20, 8:42 PM
Unknown Object (File)
Sun, Nov 17, 10:23 AM
Unknown Object (File)
Oct 17 2024, 6:50 PM
Unknown Object (File)
Oct 17 2024, 6:47 PM
Unknown Object (File)
Oct 17 2024, 6:46 PM
Unknown Object (File)
Oct 17 2024, 6:44 PM
Unknown Object (File)
Oct 7 2024, 12:03 PM

Details

Summary

adds a new FIELD and a new VALUE to support this. Slightly dodgy because priorities do not have phids so we have to special case how we handle this in a few spots. Ref T4294.

Test Plan

made a new rule to get cc'd on unbreak now and wishlist tasks. verified got cc'd correctly and not cc'd correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This looks perfectly reasonable to me.

At some point I want to make the typeahead datasource modular so each application can define result types and it's easier to add new stuff, but I'll probably tackle that when I get back around to that diff which added icons to results.