Page MenuHomePhabricator

When creating foreign stubs during SVN import, mark them imported
ClosedPublic

Authored by epriestley on Feb 3 2014, 5:04 PM.
Tags
None
Referenced Files
F18773969: D8133.id.diff
Thu, Oct 9, 2:04 PM
F18769247: D8133.diff
Wed, Oct 8, 6:56 AM
F18622767: D8133.id18393.diff
Sep 15 2025, 12:54 PM
F18602603: D8133.diff
Sep 13 2025, 3:37 PM
F18591431: D8133.diff
Sep 12 2025, 9:13 AM
F18084786: D8133.id18400.diff
Aug 5 2025, 5:27 PM
F18051756: D8133.id18401.diff
Aug 4 2025, 12:22 AM
F18006981: D8133.id.diff
Aug 2 2025, 1:38 PM
Subscribers

Details

Summary

See https://github.com/facebook/phabricator/issues/501. I think the issue here is that we created a foreign stub for commit X-1, probably because commit X was created by running svn cp y x.

Test Plan

I'll write a separate test for this before I land it. Huge pain to test.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bummer on the test pain :/

Yeah -- it's not the end of the world, it just took 30 seconds to write this and is going to take 20 minutes to write a test for.

epriestley updated this revision to Unknown Object (????).Feb 3 2014, 8:20 PM
  • Yep, spent like 20 minutes writing a test case for this.