Page MenuHomePhabricator

When creating foreign stubs during SVN import, mark them imported
ClosedPublic

Authored by epriestley on Feb 3 2014, 5:04 PM.
Tags
None
Referenced Files
F14062466: D8133.diff
Mon, Nov 18, 12:27 PM
F14049985: D8133.diff
Thu, Nov 14, 3:49 PM
F14038005: D8133.id18393.diff
Sun, Nov 10, 8:48 PM
F14035565: D8133.diff
Sun, Nov 10, 6:31 AM
Unknown Object (File)
Oct 20 2024, 5:15 AM
Unknown Object (File)
Oct 20 2024, 2:22 AM
Unknown Object (File)
Oct 7 2024, 12:12 PM
Unknown Object (File)
Oct 7 2024, 12:12 PM
Subscribers

Details

Summary

See https://github.com/facebook/phabricator/issues/501. I think the issue here is that we created a foreign stub for commit X-1, probably because commit X was created by running svn cp y x.

Test Plan

I'll write a separate test for this before I land it. Huge pain to test.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bummer on the test pain :/

Yeah -- it's not the end of the world, it just took 30 seconds to write this and is going to take 20 minutes to write a test for.

epriestley updated this revision to Unknown Object (????).Feb 3 2014, 8:20 PM
  • Yep, spent like 20 minutes writing a test case for this.