Page MenuHomePhabricator

When creating foreign stubs during SVN import, mark them imported
ClosedPublic

Authored by epriestley on Feb 3 2014, 5:04 PM.
Tags
None
Referenced Files
F19285690: D8133.diff
Tue, Dec 23, 5:54 AM
F19232792: D8133.diff
Sun, Dec 21, 5:28 PM
F19096011: D8133.id.diff
Dec 4 2025, 7:29 AM
F18914301: D8133.diff
Nov 9 2025, 6:47 AM
F18851023: D8133.id18400.diff
Oct 30 2025, 9:30 PM
F18841687: D8133.diff
Oct 28 2025, 10:33 AM
F18840088: D8133.id18393.diff
Oct 27 2025, 8:57 PM
F18832865: D8133.diff
Oct 25 2025, 11:30 PM
Subscribers

Details

Summary

See https://github.com/facebook/phabricator/issues/501. I think the issue here is that we created a foreign stub for commit X-1, probably because commit X was created by running svn cp y x.

Test Plan

I'll write a separate test for this before I land it. Huge pain to test.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bummer on the test pain :/

Yeah -- it's not the end of the world, it just took 30 seconds to write this and is going to take 20 minutes to write a test for.

epriestley updated this revision to Unknown Object (????).Feb 3 2014, 8:20 PM
  • Yep, spent like 20 minutes writing a test case for this.