Page MenuHomePhabricator

When creating foreign stubs during SVN import, mark them imported
ClosedPublic

Authored by epriestley on Feb 3 2014, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 28, 5:39 PM
Unknown Object (File)
Wed, May 28, 1:39 AM
Unknown Object (File)
Sat, May 10, 12:38 AM
Unknown Object (File)
Apr 19 2025, 1:13 AM
Unknown Object (File)
Apr 9 2025, 3:46 AM
Unknown Object (File)
Apr 1 2025, 8:20 AM
Unknown Object (File)
Mar 29 2025, 6:32 PM
Unknown Object (File)
Mar 29 2025, 3:47 PM
Subscribers

Details

Summary

See https://github.com/facebook/phabricator/issues/501. I think the issue here is that we created a foreign stub for commit X-1, probably because commit X was created by running svn cp y x.

Test Plan

I'll write a separate test for this before I land it. Huge pain to test.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bummer on the test pain :/

Yeah -- it's not the end of the world, it just took 30 seconds to write this and is going to take 20 minutes to write a test for.

epriestley updated this revision to Unknown Object (????).Feb 3 2014, 8:20 PM
  • Yep, spent like 20 minutes writing a test case for this.