Page MenuHomePhabricator

When creating foreign stubs during SVN import, mark them imported
ClosedPublic

Authored by epriestley on Feb 3 2014, 5:04 PM.
Tags
None
Referenced Files
F15461432: D8133.id18393.diff
Tue, Apr 1, 8:20 AM
F15454441: D8133.id18401.diff
Sat, Mar 29, 6:32 PM
F15454018: D8133.id.diff
Sat, Mar 29, 3:47 PM
F15451018: D8133.id18400.diff
Fri, Mar 28, 7:42 PM
F15446460: D8133.diff
Thu, Mar 27, 7:10 PM
F15444279: D8133.diff
Thu, Mar 27, 8:49 AM
F15413197: D8133.id18400.diff
Wed, Mar 19, 5:27 PM
F15402964: D8133.id.diff
Tue, Mar 18, 1:21 AM
Subscribers

Details

Summary

See https://github.com/facebook/phabricator/issues/501. I think the issue here is that we created a foreign stub for commit X-1, probably because commit X was created by running svn cp y x.

Test Plan

I'll write a separate test for this before I land it. Huge pain to test.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bummer on the test pain :/

Yeah -- it's not the end of the world, it just took 30 seconds to write this and is going to take 20 minutes to write a test for.

epriestley updated this revision to Unknown Object (????).Feb 3 2014, 8:20 PM
  • Yep, spent like 20 minutes writing a test case for this.