Page MenuHomePhabricator

Distinguish between "Remote URI" and "Clone URI" in Repositories
ClosedPublic

Authored by epriestley on Jan 29 2014, 8:35 PM.

Details

Summary

Hosted repositories have muddied this distinction somewhat. In some cases, we only want to use the real remote URI, and the call is only relevant for imported repositories.

In other cases, we want the URI we'd plug into git clone.

Move this logic into PhabricatorRepository and make the distinction more clear.

Test Plan

Viewed SVN, Git, and Mercurial hosted and remote repositories, all the URIs looked reasonable.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 29 2014, 8:45 PM
  • Don't strip username from hosted SSH repositories.