Page MenuHomePhabricator

Arc output the correct action being taken
ClosedPublic

Authored by guywarner on Jan 28 2014, 3:24 PM.
Tags
None
Referenced Files
F15453464: D8085.diff
Sat, Mar 29, 12:02 PM
F15431867: D8085.id18293.diff
Mon, Mar 24, 3:02 PM
F15381028: D8085.id18292.diff
Fri, Mar 14, 5:32 AM
F15379641: D8085.id18290.diff
Thu, Mar 13, 10:32 PM
F15341251: D8085.diff
Sun, Mar 9, 7:16 PM
Unknown Object (File)
Feb 23 2025, 9:55 PM
Unknown Object (File)
Feb 22 2025, 10:52 PM
Unknown Object (File)
Feb 12 2025, 11:46 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rARC14f2f7fdd204: Arc output the correct action being taken
Summary

Refs T3929 - If arc is merging it will say merging * into * vs always saying rebasing * onto *

Test Plan

Make arc do a rebase, then a merge

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Won't this make it print out both messages? i.e., it will print:

Rebasing..
Merging...

Am I just crazy? I just woke up so let me know if I'm just misreading.

src/workflow/ArcanistLandWorkflow.php
604

I'd expect that the rebase message should go above this line.

guywarner updated this revision to Unknown Object (????).Jan 28 2014, 4:53 PM

That's what happens after I try to do a quick ticket after just waking up.

Moved the rebase echo below if (shouldUpdatewithRebase).

Whew, glad I'm not going crazy. Thanks!