Page MenuHomePhabricator

Arc output the correct action being taken
ClosedPublic

Authored by guywarner on Jan 28 2014, 3:24 PM.
Tags
None
Referenced Files
F13990157: D8085.id18290.diff
Tue, Oct 22, 1:41 AM
F13986011: D8085.diff
Mon, Oct 21, 12:03 AM
F13985073: D8085.id18293.diff
Sun, Oct 20, 5:54 PM
F13958289: D8085.id.diff
Mon, Oct 14, 1:53 PM
Unknown Object (File)
Sep 30 2024, 7:01 PM
Unknown Object (File)
Sep 24 2024, 10:48 AM
Unknown Object (File)
Sep 14 2024, 11:18 PM
Unknown Object (File)
Sep 14 2024, 11:16 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rARC14f2f7fdd204: Arc output the correct action being taken
Summary

Refs T3929 - If arc is merging it will say merging * into * vs always saying rebasing * onto *

Test Plan

Make arc do a rebase, then a merge

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Won't this make it print out both messages? i.e., it will print:

Rebasing..
Merging...

Am I just crazy? I just woke up so let me know if I'm just misreading.

src/workflow/ArcanistLandWorkflow.php
604

I'd expect that the rebase message should go above this line.

guywarner updated this revision to Unknown Object (????).Jan 28 2014, 4:53 PM

That's what happens after I try to do a quick ticket after just waking up.

Moved the rebase echo below if (shouldUpdatewithRebase).

Whew, glad I'm not going crazy. Thanks!