Page MenuHomePhabricator

Add `diffusion.querycommits` and deprecate `diffusion.getcommits`
ClosedPublic

Authored by epriestley on Jan 27 2014, 5:12 PM.
Tags
None
Referenced Files
F14000514: D8077.id18275.diff
Thu, Oct 24, 10:27 PM
F13998272: D8077.id18275.diff
Thu, Oct 24, 8:32 AM
F13997723: D8077.id18282.diff
Thu, Oct 24, 5:51 AM
F13997428: D8077.id.diff
Thu, Oct 24, 4:29 AM
F13997377: D8077.id18282.diff
Thu, Oct 24, 4:05 AM
F13997257: D8077.diff
Thu, Oct 24, 3:15 AM
F13997211: D8077.id.diff
Thu, Oct 24, 3:01 AM
F13996854: D8077.diff
Thu, Oct 24, 12:30 AM
Subscribers

Details

Summary

Fixes T4344. diffusion.getcommits is nasty old bad news. Implement a modern query method.

This method provides limit/paging in a somewhat abstract way so it's sort of ultramodern, but I didn't want the default behavior to return a million rows. I'll probably move more stuff toward this over time, now that cursor paging is pervasive. Here, we needed extra metadata (the identifier map) anyway.

Test Plan

Used console to execute command.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped