round them there corners, to create more of a "bubble" effect in legalpad. Ref T3116.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rPf6e9d36c329c: Legalpad - style NOTE IMPORTANT WARNING remarkup slightly differently
see screenshot, which demonstrates new style works
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/legalpad/controller/LegalpadDocumentSignController.php | ||
|---|---|---|
| 207–213 | I feel like we changed this (or maybe it was javelin includes?) but I can't remember the details. | |
Comment Actions
These should probably be px -- I think the em stuff is mostly old crazy @epriestley leftovers.
(@chad, feel free to yell at us.)
| src/applications/legalpad/controller/LegalpadDocumentSignController.php | ||
|---|---|---|
| 207–213 | Oh, right -- there should be a $this->requireResource(...) now I think. | |
Comment Actions
...i remembered!
require_celerity_resource => $this->requireResource in controllers...
Comment Actions
...and switched to pixels. also made it a little curvier for maximum "bubble-look" for one-line NOTEs
| webroot/rsrc/css/application/legalpad/legalpad-document.css | ||
|---|---|---|
| 17 | btw, don't need to do -moz-border-radius, it's been unused just border-radius 22 versions. | |