Don't let Diffusion show that an importing repository is "100%" imported
ClosedPublic
Actions

Authored by epriestley on Jan 24 2014, 7:05 PM.

Tags

None

Referenced Files

	F15507267: D8058.id.diff
	Tue, Apr 15, 6:01 PM

	F15503559: D8058.diff
	Mon, Apr 14, 10:44 AM

	F15430605: D8058.id.diff
	Mon, Mar 24, 8:25 AM

	F15412444: D8058.diff
	Wed, Mar 19, 1:02 PM

	F15401120: D8058.diff
	Mar 17 2025, 3:50 PM

	F15377783: D8058.id18233.diff
	Mar 13 2025, 10:46 AM

	F15293713: D8058.id18237.diff
	Mar 5 2025, 4:34 AM

	F15293712: D8058.id18233.diff
	Mar 5 2025, 4:34 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP53687827c643: Don't let Diffusion show that an importing repository is "100%" imported

Summary

A few users have hit this and found it confusing. Currently, it means "more than 99.95%", which is very different from "100%". Instead:

show an extra digit of precision; and
cap the display at "99.99%", so it's more clear that work is still happening.

Test Plan

Faked it and saw it cap at 99.99%.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 24 2014, 7:24 PM

Closed by commit rP53687827c643 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryEditMainController.php

8 lines

Diff 18237

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Don't let Diffusion show that an importing repository is "100%" importedClosedPublicActions