Page MenuHomePhabricator

Don't let Diffusion show that an importing repository is "100%" imported
ClosedPublic

Authored by epriestley on Jan 24 2014, 7:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 5:58 PM
Unknown Object (File)
Sun, Dec 15, 5:58 PM
Unknown Object (File)
Sun, Dec 15, 5:27 PM
Unknown Object (File)
Sun, Dec 15, 5:27 PM
Unknown Object (File)
Sat, Dec 7, 12:40 PM
Unknown Object (File)
Wed, Dec 4, 12:24 PM
Unknown Object (File)
Wed, Dec 4, 12:24 PM
Unknown Object (File)
Wed, Dec 4, 12:24 PM
Subscribers

Details

Summary

A few users have hit this and found it confusing. Currently, it means "more than 99.95%", which is very different from "100%". Instead:

  • show an extra digit of precision; and
  • cap the display at "99.99%", so it's more clear that work is still happening.
Test Plan

Faked it and saw it cap at 99.99%.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped