Page MenuHomePhabricator

Straighten out absolute/relative URIs in login providers
ClosedPublic

Authored by epriestley on Jan 23 2014, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 1:16 AM
Unknown Object (File)
Tue, Dec 17, 6:18 AM
Unknown Object (File)
Tue, Dec 17, 5:24 AM
Unknown Object (File)
Sun, Dec 15, 5:25 PM
Unknown Object (File)
Sun, Dec 15, 5:24 PM
Unknown Object (File)
Fri, Dec 13, 9:26 PM
Unknown Object (File)
Sun, Dec 8, 1:36 AM
Unknown Object (File)
Thu, Dec 5, 9:10 PM
Subscribers

Details

Summary

Ref T4339. Login providers use absolute URIs, but the ones that rely on local form submits should not, because we want to include CSRF tokens where applicable.

Instead, make the default be relative URIs and turn them into absolute ones for the callback proivders.

Test Plan

Clicked, like, every login button.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 23 2014, 7:23 PM
  • Fix a couple more cases.