Minor, adds the Callsign and changes to cards view when listing repositories.
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rPad8d17f5795a: Use callsigns, cards on repository lists
Reload sandbox list of repositories, see new items.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
This should be rXYZ instead of XYZ, similar to how we list T123 instead of just 123.
(If you really want, you could define getMonogram() and use it here.)
Comment Actions
So anytime we display a repository callsign to the user, we want it as
rCALLSIGN
?
Its slightly inconsistent right now so I just wanted to make sure I understood the direction.
Comment Actions
I can see it being slightly confusing, for example, my git folder has PCORP, not rPCORP in it.
Comment Actions
Anywhere where you'd use T123 if it was a task, use rABC.
Anywhere you'd use 123 if it was a task, use ABC.
Basically, callsigns are just like more-memorable IDs.
I think we're mostly consistent about this -- what are the exceptions you're aware of?
Comment Actions
Only saw one spot so far. For example, https://secure.phabricator.com/diffusion/P/ - in the object detail pain, the "Callsign: P" part should be "Callsign: rP" maybe? Although in the "what would you do if this were a task?" mindset, I'd just remove that field altogether.