Paths

Table of Contentst

Add PHPAST tests for static class expressions, callable, traits, finally and short array syntax
ClosedPublic
Actions

Authored by epriestley on Jan 21 2014, 7:01 PM.

Tags

None

Referenced Files

	F15452979: D8030.diff
	Sat, Mar 29, 8:33 AM

	F15375725: D8030.diff
	Wed, Mar 12, 11:49 PM

	F15332942: D8030.id18153.diff
	Fri, Mar 7, 10:30 PM

	F15332941: D8030.id18153.diff
	Fri, Mar 7, 10:30 PM

	F15328587: D8030.diff
	Fri, Mar 7, 5:50 AM

	F15328586: D8030.diff
	Fri, Mar 7, 5:50 AM

	F15328559: D8030.id18174.diff
	Fri, Mar 7, 5:48 AM

	F15328558: D8030.id18174.diff
	Fri, Mar 7, 5:48 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
Firehed

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Commits

rPHUc2e32dcf8f29: Add PHPAST tests for static class expressions, callable, traits, finally and…

Summary

Ref T4334. These are all failing, but should pass. They pass with php -l on modern PHP.

Test Plan

Ran unit tests.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 21 2014, 10:19 PM

Closed by commit rPHUc2e32dcf8f29 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

php-callable-typehint.php.expect

139 lines

php-callable-typehint.php.test

4 lines

php-class-expr.php.test

4 lines

php-finally.php.test

2 lines

php-short-array.php.test

2 lines

php-traits.php.test

26 lines

Diff 18174

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.test

View Options

src/parser/xhpast/tests/data/php-class-expr.php.test

View Options

src/parser/xhpast/tests/data/php-finally.php.test

View Options

src/parser/xhpast/tests/data/php-short-array.php.test

View Options

src/parser/xhpast/tests/data/php-traits.php.test

Add PHPAST tests for static class expressions, callable, traits, finally and short array syntaxClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18174

src/parser/xhpast/__tests__/data/php-callable-typehint.php.expect

src/parser/xhpast/__tests__/data/php-callable-typehint.php.test

src/parser/xhpast/__tests__/data/php-class-expr.php.test

src/parser/xhpast/__tests__/data/php-finally.php.test

src/parser/xhpast/__tests__/data/php-short-array.php.test

src/parser/xhpast/__tests__/data/php-traits.php.test

Add PHPAST tests for static class expressions, callable, traits, finally and short array syntax
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

src/parser/xhpast/tests/data/php-callable-typehint.php.test

src/parser/xhpast/tests/data/php-class-expr.php.test

src/parser/xhpast/tests/data/php-finally.php.test

src/parser/xhpast/tests/data/php-short-array.php.test

src/parser/xhpast/tests/data/php-traits.php.test