Page MenuHomePhabricator

Improve exception reporting behavior for core exceptions
ClosedPublic

Authored by epriestley on Jan 21 2014, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 25, 2:24 PM
Unknown Object (File)
Wed, May 7, 5:18 AM
Unknown Object (File)
Mon, May 5, 7:31 AM
Unknown Object (File)
Apr 10 2025, 8:20 AM
Unknown Object (File)
Apr 8 2025, 2:42 PM
Unknown Object (File)
Apr 8 2025, 11:29 AM
Unknown Object (File)
Apr 7 2025, 6:06 PM
Unknown Object (File)
Apr 2 2025, 11:55 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

See https://github.com/facebook/phabricator/issues/487. If an exception is thrown too high in the stack for the main exception handling to deal with it, we currently never report a stack trace. Instead:

  • Always report a stack trace to the error log.
  • With developer mode, also report a stack trace to the screen.
Test Plan

Added a high-level throw and hit both cases. Got traces in the log and traces-under-developer-mode on screen.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped