Page MenuHomePhabricator

Improve exception reporting behavior for core exceptions
ClosedPublic

Authored by epriestley on Jan 21 2014, 3:53 PM.
Tags
None
Referenced Files
F17188786: D8022.id18162.diff
Fri, Jun 20, 8:35 AM
Unknown Object (File)
Wed, Jun 18, 10:59 AM
Unknown Object (File)
Tue, Jun 17, 7:01 PM
Unknown Object (File)
Mon, Jun 9, 1:52 AM
Unknown Object (File)
Sun, May 25, 2:24 PM
Unknown Object (File)
May 7 2025, 5:18 AM
Unknown Object (File)
May 5 2025, 7:31 AM
Unknown Object (File)
Apr 10 2025, 8:20 AM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

See https://github.com/facebook/phabricator/issues/487. If an exception is thrown too high in the stack for the main exception handling to deal with it, we currently never report a stack trace. Instead:

  • Always report a stack trace to the error log.
  • With developer mode, also report a stack trace to the screen.
Test Plan

Added a high-level throw and hit both cases. Got traces in the log and traces-under-developer-mode on screen.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped