Page MenuHomePhabricator

Improve exception reporting behavior for core exceptions
ClosedPublic

Authored by epriestley on Jan 21 2014, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 6:14 PM
Unknown Object (File)
Sat, Jan 25, 3:52 AM
Unknown Object (File)
Wed, Jan 22, 5:20 PM
Unknown Object (File)
Sat, Jan 18, 12:01 AM
Unknown Object (File)
Jan 3 2025, 7:27 AM
Unknown Object (File)
Jan 1 2025, 11:37 PM
Unknown Object (File)
Jan 1 2025, 11:23 PM
Unknown Object (File)
Dec 26 2024, 12:13 AM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

See https://github.com/facebook/phabricator/issues/487. If an exception is thrown too high in the stack for the main exception handling to deal with it, we currently never report a stack trace. Instead:

  • Always report a stack trace to the error log.
  • With developer mode, also report a stack trace to the screen.
Test Plan

Added a high-level throw and hit both cases. Got traces in the log and traces-under-developer-mode on screen.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped