Page MenuHomePhabricator

Improve exception reporting behavior for core exceptions
ClosedPublic

Authored by epriestley on Jan 21 2014, 3:53 PM.
Tags
None
Referenced Files
F18833410: D8022.diff
Sun, Oct 26, 3:07 AM
F18791903: D8022.diff
Thu, Oct 16, 6:35 PM
F18619773: D8022.diff
Sep 15 2025, 3:23 AM
F18619771: D8022.diff
Sep 15 2025, 3:22 AM
F18590166: D8022.id18162.diff
Sep 12 2025, 5:22 AM
F18486359: D8022.diff
Sep 3 2025, 6:28 PM
F18088610: D8022.id18162.diff
Aug 6 2025, 8:38 AM
F17971764: D8022.id18143.diff
Aug 1 2025, 3:23 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

See https://github.com/facebook/phabricator/issues/487. If an exception is thrown too high in the stack for the main exception handling to deal with it, we currently never report a stack trace. Instead:

  • Always report a stack trace to the error log.
  • With developer mode, also report a stack trace to the screen.
Test Plan

Added a high-level throw and hit both cases. Got traces in the log and traces-under-developer-mode on screen.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped