Page MenuHomePhabricator

Improve exception reporting behavior for core exceptions
ClosedPublic

Authored by epriestley on Jan 21 2014, 3:53 PM.
Tags
None
Referenced Files
F19804184: D8022.diff
Mon, Mar 2, 5:48 AM
F19783836: D8022.diff
Tue, Feb 24, 5:41 PM
F19709646: D8022.id18143.diff
Wed, Feb 11, 3:02 PM
F19635015: D8022.id.diff
Feb 5 2026, 9:48 AM
F19614494: D8022.id18162.diff
Feb 3 2026, 10:03 PM
F19567935: D8022.diff
Jan 31 2026, 9:36 PM
F19532803: D8022.id18162.diff
Jan 20 2026, 1:42 PM
F19524306: D8022.id18143.diff
Jan 17 2026, 11:44 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

See https://github.com/facebook/phabricator/issues/487. If an exception is thrown too high in the stack for the main exception handling to deal with it, we currently never report a stack trace. Instead:

  • Always report a stack trace to the error log.
  • With developer mode, also report a stack trace to the screen.
Test Plan

Added a high-level throw and hit both cases. Got traces in the log and traces-under-developer-mode on screen.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped