Page MenuHomePhabricator

Improve exception reporting behavior for core exceptions
ClosedPublic

Authored by epriestley on Jan 21 2014, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 2:04 AM
Unknown Object (File)
Sat, Apr 27, 12:34 AM
Unknown Object (File)
Mon, Apr 22, 10:30 PM
Unknown Object (File)
Sat, Apr 20, 6:18 PM
Unknown Object (File)
Thu, Apr 11, 4:32 AM
Unknown Object (File)
Thu, Apr 11, 4:32 AM
Unknown Object (File)
Thu, Apr 11, 4:07 AM
Unknown Object (File)
Thu, Apr 11, 3:45 AM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

See https://github.com/facebook/phabricator/issues/487. If an exception is thrown too high in the stack for the main exception handling to deal with it, we currently never report a stack trace. Instead:

  • Always report a stack trace to the error log.
  • With developer mode, also report a stack trace to the screen.
Test Plan

Added a high-level throw and hit both cases. Got traces in the log and traces-under-developer-mode on screen.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped