Page MenuHomePhabricator

Move more discovery responsibilities into DiscoveryEngine
ClosedPublic

Authored by epriestley on Jan 17 2014, 9:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:43 PM
Unknown Object (File)
Sun, Nov 17, 12:27 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Mon, Nov 4, 10:53 AM
Unknown Object (File)
Sat, Oct 26, 10:54 PM
Unknown Object (File)
Oct 20 2024, 5:48 PM
Subscribers

Details

Summary

Ref T4327. This moves the last pieces of discovery responsibility out of the PullLocal daemon and into the DiscoveryEngine.

(This makes it easier to discover repositories in unit tests in the future, since we don't need to build a PullLocal daemon and can just build a DiscoveryEngine.)

Test Plan

Ran phd debug pulllocal. Ran repostory discover.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
61

This indirectly fixes a small potential bug, where a commit could get marked in the cache but not actually recorded.