Page MenuHomePhabricator

Remove all the multi-pass autoclose-branch separate-cache / seenOnBranches junk
ClosedPublic

Authored by epriestley on Jan 16 2014, 11:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 3:33 PM
Unknown Object (File)
Sat, Nov 16, 5:41 AM
Unknown Object (File)
Mon, Nov 11, 9:46 PM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Mon, Nov 4, 10:53 AM
Unknown Object (File)
Sun, Nov 3, 2:19 AM
Subscribers

Details

Summary

Ref T4327. Simplify the git discovery process so I can move it to the DiscoveryEngine, so I can make change parsing testable.

In particular:

  • As an optimization, we process closeable branches ("master") first, then process uncloseable branches ("epriestley-devel"). This means that in the common case we can insert a commit as closeable immediately when it is discovered, the first pass through the pipeline will get it right, and the "ref update" step will never need to do any meaningful work.
  • Commits which do not initially appear on a closeable branch, but later move to one (via merges or ref moves) will now be caught in the ref update step, have the closeable flag set, and have a message step re-queued.
  • We no longer need to do a separate discovery step on closable branches.
  • We no longer need to keep track of seenOnBranches.
Test Plan

Ran discovery on repositories after pushing commits, got reasonable results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped