Page MenuHomePhabricator

Legalpad - a few rough edges smoothed...
ClosedPublic

Authored by btrahan on Jan 16 2014, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 3, 9:39 PM
Unknown Object (File)
Mon, Feb 3, 7:59 PM
Unknown Object (File)
Wed, Jan 29, 7:50 AM
Unknown Object (File)
Jan 18 2025, 3:52 AM
Unknown Object (File)
Jan 17 2025, 5:25 PM
Unknown Object (File)
Dec 28 2024, 11:38 PM
Unknown Object (File)
Dec 24 2024, 4:23 PM
Unknown Object (File)
Dec 21 2024, 12:34 AM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc40420eb7465: Legalpad - a few rough edges smoothed...
Summary

does a few smallish things... Ref T3116

  • adds an action to "sign document", thus improving visiblity of this feature from 0 to some value more than 0
  • adds a crumb on the edit page to get back to the view page
  • warns the user on the edit page IFF signatures exist for the current version that their edits could invalidate those signatures
    • adds a "needSignatures" option to the Document Query class
Test Plan

click the new UI elements and they worked. edited a document with signatures, noted warning UI, edited anyway, noted warning UI correctly disappeared on new edit. also verified a single signature had the correct translation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped