Page MenuHomePhabricator

Legalpad - a few rough edges smoothed...
ClosedPublic

Authored by btrahan on Jan 16 2014, 10:29 PM.
Tags
None
Referenced Files
F13230262: D7983.id18063.diff
Mon, May 20, 10:18 PM
F13203394: D7983.diff
Tue, May 14, 11:42 PM
F13189354: D7983.diff
Sat, May 11, 5:53 AM
Unknown Object (File)
Tue, May 7, 9:37 AM
Unknown Object (File)
Fri, May 3, 9:35 AM
Unknown Object (File)
Sun, Apr 28, 4:32 AM
Unknown Object (File)
Thu, Apr 25, 1:37 AM
Unknown Object (File)
Tue, Apr 23, 8:43 AM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc40420eb7465: Legalpad - a few rough edges smoothed...
Summary

does a few smallish things... Ref T3116

  • adds an action to "sign document", thus improving visiblity of this feature from 0 to some value more than 0
  • adds a crumb on the edit page to get back to the view page
  • warns the user on the edit page IFF signatures exist for the current version that their edits could invalidate those signatures
    • adds a "needSignatures" option to the Document Query class
Test Plan

click the new UI elements and they worked. edited a document with signatures, noted warning UI, edited anyway, noted warning UI correctly disappeared on new edit. also verified a single signature had the correct translation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped