Page MenuHomePhabricator

Legalpad - a few rough edges smoothed...
ClosedPublic

Authored by btrahan on Jan 16 2014, 10:29 PM.
Tags
None
Referenced Files
F19506825: D7983.id18063.diff
Fri, Jan 9, 5:07 PM
F19506646: D7983.id18062.diff
Fri, Jan 9, 4:50 PM
F19061358: D7983.id18062.diff
Nov 29 2025, 12:13 PM
F18999084: D7983.diff
Nov 20 2025, 8:05 PM
F18867121: D7983.id18063.diff
Nov 3 2025, 9:37 PM
F18850369: D7983.id.diff
Oct 30 2025, 4:12 PM
F18846066: D7983.diff
Oct 29 2025, 4:23 PM
F18802559: D7983.diff
Oct 17 2025, 7:27 PM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc40420eb7465: Legalpad - a few rough edges smoothed...
Summary

does a few smallish things... Ref T3116

  • adds an action to "sign document", thus improving visiblity of this feature from 0 to some value more than 0
  • adds a crumb on the edit page to get back to the view page
  • warns the user on the edit page IFF signatures exist for the current version that their edits could invalidate those signatures
    • adds a "needSignatures" option to the Document Query class
Test Plan

click the new UI elements and they worked. edited a document with signatures, noted warning UI, edited anyway, noted warning UI correctly disappeared on new edit. also verified a single signature had the correct translation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped