Page MenuHomePhabricator

Legalpad - a few rough edges smoothed...
ClosedPublic

Authored by btrahan on Jan 16 2014, 10:29 PM.
Tags
None
Referenced Files
F15525145: D7983.diff
Mon, Apr 21, 12:28 PM
F15431161: D7983.id18063.diff
Mar 24 2025, 10:53 AM
F15427933: D7983.id.diff
Mar 23 2025, 5:15 PM
F15423639: D7983.diff
Mar 22 2025, 4:26 PM
F15413724: D7983.diff
Mar 19 2025, 8:55 PM
F15412078: D7983.id.diff
Mar 19 2025, 11:11 AM
Unknown Object (File)
Feb 23 2025, 9:15 AM
Unknown Object (File)
Feb 22 2025, 11:00 PM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc40420eb7465: Legalpad - a few rough edges smoothed...
Summary

does a few smallish things... Ref T3116

  • adds an action to "sign document", thus improving visiblity of this feature from 0 to some value more than 0
  • adds a crumb on the edit page to get back to the view page
  • warns the user on the edit page IFF signatures exist for the current version that their edits could invalidate those signatures
    • adds a "needSignatures" option to the Document Query class
Test Plan

click the new UI elements and they worked. edited a document with signatures, noted warning UI, edited anyway, noted warning UI correctly disappeared on new edit. also verified a single signature had the correct translation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped