Page MenuHomePhabricator
Differential D7974

Fix excessively aggressive capturing of hyperlinks in Remarkup
ClosedPublic
Actions

Authored by epriestley on Jan 15 2014, 7:24 PM.
Tags
None
Referenced Files
F19506594: D7974.id18043.diff
Fri, Jan 9, 4:49 PM
F18992622: D7974.diff
Nov 19 2025, 3:26 AM
F18805664: D7974.id18044.diff
Oct 18 2025, 4:05 PM
F18769163: D7974.id.diff
Oct 8 2025, 6:41 AM
F18766303: D7974.diff
Oct 7 2025, 3:58 PM
F18764414: D7974.id.diff
Oct 7 2025, 5:54 AM
F18745382: D7974.id18043.diff
Oct 3 2025, 6:28 AM
F18585700: D7974.id18043.diff
Sep 11 2025, 4:07 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Firehed
Maniphest Tasks
T4319: Remarkup text rendering bug
Commits
rPHU22285e941272: Fix excessively aggressive capturing of hyperlinks in Remarkup
Summary

Fixes T4319. See that task for examples. The "ungreedy" hyperlink rule is still a bit too greedy.

Test Plan

Added failing tests, made them pass.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Firehed accepted this revision.Jan 15 2014, 7:30 PM

Confirmed to fix T4319 on my install.

epriestley closed this revision.Jan 15 2014, 7:31 PM

Closed by commit rPHU22285e941272 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
6 lines
18 lines
remarkup/
4 lines
markuprule/
7 lines

Diff 18044

View Options

src/markup/engine/__tests__/remarkup/link-brackets.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/link-mixed.txt

Loading...
View Options

src/markup/engine/remarkup/PhutilRemarkupBlockStorage.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleHyperlink.php

Loading...
Phabricator · Built by Phacility