Page MenuHomePhabricator
Differential D7974

Fix excessively aggressive capturing of hyperlinks in Remarkup
ClosedPublic
Actions

Authored by epriestley on Jan 15 2014, 7:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 31, 5:56 PM
Unknown Object (File)
May 31 2026, 3:59 AM
Unknown Object (File)
Mar 1 2026, 6:50 PM
Unknown Object (File)
Feb 5 2026, 10:15 AM
Unknown Object (File)
Feb 4 2026, 1:21 PM
Unknown Object (File)
Feb 3 2026, 9:50 AM
Unknown Object (File)
Jan 21 2026, 2:19 AM
Unknown Object (File)
Jan 9 2026, 4:49 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Firehed
Maniphest Tasks
T4319: Remarkup text rendering bug
Commits
rPHU22285e941272: Fix excessively aggressive capturing of hyperlinks in Remarkup
Summary

Fixes T4319. See that task for examples. The "ungreedy" hyperlink rule is still a bit too greedy.

Test Plan

Added failing tests, made them pass.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Firehed accepted this revision.Jan 15 2014, 7:30 PM

Confirmed to fix T4319 on my install.

epriestley closed this revision.Jan 15 2014, 7:31 PM

Closed by commit rPHU22285e941272 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
6 lines
18 lines
remarkup/
4 lines
markuprule/
7 lines

Diff 18044

View Options

src/markup/engine/__tests__/remarkup/link-brackets.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/link-mixed.txt

Loading...
View Options

src/markup/engine/remarkup/PhutilRemarkupBlockStorage.php

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleHyperlink.php

Loading...
Phabricator · Built by Phacility