Paths

Table of Contentst

Differential D7966

Perform search indexing in the worker queue and respect `bin/search index --background`
ClosedPublic
Actions

Authored by epriestley on Jan 14 2014, 8:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 2:51 AM

	Unknown Object (File)
	Thu, Dec 12, 6:31 AM

	Unknown Object (File)
	Tue, Dec 10, 8:35 PM

	Unknown Object (File)
	Sat, Dec 7, 9:09 PM

	Unknown Object (File)
	Wed, Dec 4, 3:16 AM

	Unknown Object (File)
	Sat, Nov 30, 1:54 PM

	Unknown Object (File)
	Tue, Nov 26, 1:55 PM

	Unknown Object (File)
	Fri, Nov 22, 6:56 AM

Subscribers

Details

Reviewers

Maniphest Tasks

Restricted Maniphest Task
Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPa716fe99f3b2: Perform search indexing in the worker queue and respect `bin/search index…

Summary

Fixes T3857. Earlier work made this trivial and just left product questions, which I've answered by requiring the daemons to run on reasonable installs.

Test Plan

Ran bin/search index and bin/search index --background. Observed indexes write in the former case and tasks queue in the latter case. Commented with a unique string on a revision and searched for it a moment later, got exactly one result (that revision), verifying that reindexing works correctly.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 14 2014, 9:12 PM

btrahan added inline comments.

src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
32	the it sentence is hard to read

Make it the it easier to read it.

Closed by commit rPa716fe99f3b2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

audit/

editor/

PhabricatorAuditCommentEditor.php

2 lines

differential/

editor/

DifferentialCommentEditor.php

2 lines

DifferentialRevisionEditor.php

2 lines

diffusion/

controller/

DiffusionCommitEditController.php

2 lines

people/

storage/

PhabricatorUser.php

2 lines

phriction/

editor/

PhrictionDocumentEditor.php

2 lines

project/

editor/

PhabricatorProjectEditor.php

2 lines

repository/

worker/

commitchangeparser/

PhabricatorRepositoryCommitChangeParserWorker.php

2 lines

search/

index/

PhabricatorSearchIndexer.php

11 lines

management/

PhabricatorSearchManagementIndexWorkflow.php

28 lines

worker/

PhabricatorSearchWorker.php

13 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

Diff 18023

src/__phutil_library_map__.php

Loading...

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...

src/applications/differential/editor/DifferentialCommentEditor.php

Loading...

src/applications/differential/editor/DifferentialRevisionEditor.php

Loading...

src/applications/diffusion/controller/DiffusionCommitEditController.php

Loading...

src/applications/people/storage/PhabricatorUser.php

Loading...

src/applications/phriction/editor/PhrictionDocumentEditor.php

Loading...

src/applications/project/editor/PhabricatorProjectEditor.php

Loading...

src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php

Loading...

src/applications/search/index/PhabricatorSearchIndexer.php

Loading...

src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php

Loading...

src/applications/search/worker/PhabricatorSearchWorker.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...