Fix rendering issue for LDAP configuration provider transactions
ClosedPublic
Actions

Authored by epriestley on Jan 8 2014, 1:49 PM.

Tags

None

Referenced Files

	F15422411: D7905.id17901.diff
	Sat, Mar 22, 8:05 AM

	F15419833: D7905.id.diff
	Fri, Mar 21, 9:16 AM

	F15417737: D7905.diff
	Thu, Mar 20, 6:03 PM

	F15386591: D7905.id.diff
	Sat, Mar 15, 12:55 AM

	F15332080: D7905.id17901.diff
	Fri, Mar 7, 4:29 PM

	F15332079: D7905.id.diff
	Fri, Mar 7, 4:29 PM

	F15294461: D7905.id17894.diff
	Wed, Mar 5, 8:14 AM

	F15294460: D7905.diff
	Wed, Mar 5, 8:14 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4290: PhabricatorAuthProviderConfigTransaction old value may contain other things than strings

Commits

Restricted Diffusion Commit
rP324ee4e4d539: Fix rendering issue for LDAP configuration provider transactions

Summary

Fixes T4290. At least one of the fields (realname) may have a list of items, and strlen(array('first', 'last')) produces the warning and stack trace in T4290.

Test Plan

Edited realname from an array value to an array value.
Hit error.
Applied patch.
No more error.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 8 2014, 6:26 PM

Closed by commit rP324ee4e4d539 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

provider/

PhabricatorAuthProviderLDAP.php

2 lines

Diff 17901

View Options

src/applications/auth/provider/PhabricatorAuthProviderLDAP.php

Fix rendering issue for LDAP configuration provider transactionsClosedPublicActions