Make Tables play well in PHUIObjectBoxView
ClosedPublic
Actions

Authored by chad on Jan 7 2014, 12:37 AM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T4142: Show Application Descriptions on "Home Page Preferences" Form

Commits

Restricted Diffusion Commit
rP30441fe208c4: Make Tables play well in PHUIObjectBoxView

Summary

Updates table design to use new standards, work well in PHUIObjectBox. Fixes T4142

Comma

Test Plan

Tested on Diffusion, Settings, will roll out to more places soon

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

{F99073}

{F99074}

Tables look great, but one issue inline.

I think you can swap the FormLayoutView back to a FormView? Maybe? If that doesn't work, let me know and we can sort something else out.

If that doesn't work, you can use phabricator_form() to put a style-less <form /> around some content.

src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php
199	This button doesn't actually work now (i.e., clicking it does nothing), since FormLayoutView just looks like a form, but is not actually a `<form />` tag.

Oh I wound swear PHUIFormlayoutView extended AphrontFormView. Basically I just want something unstyled. Will recheck when I get back.

Yeah that was silly. Basically AphrontFormView adds padding, which I dont want. I can either add a setNoPadding, or wrap the page in a special class. I'll probably do the latter since there isn't much re-use of the former.