Page MenuHomePhabricator

Add mailKey to macros
ClosedPublic

Authored by epriestley on Jan 6 2014, 5:40 PM.
Tags
None
Referenced Files
F18086528: D7896.id17870.diff
Aug 5 2025, 10:26 PM
F18053804: D7896.id.diff
Aug 4 2025, 5:31 AM
F18053440: D7896.id17863.diff
Aug 4 2025, 5:03 AM
F18042504: D7896.diff
Aug 3 2025, 5:02 AM
Unknown Object (File)
Jun 6 2025, 8:57 AM
Unknown Object (File)
Jun 5 2025, 2:30 PM
Unknown Object (File)
May 26 2025, 1:53 PM
Unknown Object (File)
May 21 2025, 10:22 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP6abe65bfdce3: Add mailKey to macros
Summary

If you have private replies on and a Macro reply handler set, we try to access getMailKey() and fail. See P1039 for a trace.

(Thanks to @Korvin for picking this up.)

Test Plan

Set configuration, repro'd the exception, applied the patch, then disabled/enabled a macro.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped