Page MenuHomePhabricator

Replace "Cancel Build" with "Stop", "Resume" and "Restart"

Authored by epriestley on Jan 5 2014, 7:16 PM.
Referenced Files
Unknown Object (File)
Sun, Jan 29, 7:40 AM
Unknown Object (File)
Tue, Jan 24, 3:45 PM
Unknown Object (File)
Thu, Jan 19, 1:39 PM
Unknown Object (File)
Sun, Jan 8, 8:22 PM
Unknown Object (File)
Sat, Dec 31, 10:40 PM
Unknown Object (File)
Dec 26 2022, 3:36 PM
Unknown Object (File)
Dec 12 2022, 6:42 AM
Unknown Object (File)
Dec 12 2022, 6:41 AM
"The World Burns" token, awarded by demo.



Ref T1049. Currently you can cancel a build, but now that we're tracking a lot more state we can stop, resume, and restart builds.

When the user issues a command against a build, I'm writing it into an auxiliary queue (HarbormasterBuildCommand) and then reading them out in the worker. This is mostly to avoid race messes where we try to save() the object in multiple places: basically, the BuildEngine is the only thing that writes to Build objects, and it holds a lock while it does it.

Test Plan
  • Created a plan which runs "sleep 2" a bunch of times in a row.
  • Stopped, resumed, and restarted it.

Diff Detail

Lint Skipped
Tests Skipped

Event Timeline

We need icons for these? I have play, pause, stop, etc, icons in Glyphicons.

These are the icons we're using right now -- I think they're OK, we have better ones then by all means:


epriestley updated this revision to Unknown Object (????).Jan 6 2014, 8:31 PM
  • Use fancy new icons.