Page MenuHomePhabricator

Replace "Cancel Build" with "Stop", "Resume" and "Restart"

Authored by epriestley on Jan 5 2014, 7:16 PM.



Ref T1049. Currently you can cancel a build, but now that we're tracking a lot more state we can stop, resume, and restart builds.

When the user issues a command against a build, I'm writing it into an auxiliary queue (HarbormasterBuildCommand) and then reading them out in the worker. This is mostly to avoid race messes where we try to save() the object in multiple places: basically, the BuildEngine is the only thing that writes to Build objects, and it holds a lock while it does it.

Test Plan
  • Created a plan which runs "sleep 2" a bunch of times in a row.
  • Stopped, resumed, and restarted it.

Diff Detail

Lint Skipped
Unit Tests Skipped

Event Timeline

chad added a comment.Jan 5 2014, 8:20 PM

We need icons for these? I have play, pause, stop, etc, icons in Glyphicons.

These are the icons we're using right now -- I think they're OK, we have better ones then by all means:


btrahan accepted this revision.Jan 6 2014, 7:34 PM
epriestley updated this revision to Unknown Object (????).Jan 6 2014, 8:31 PM
  • Use fancy new icons.
epriestley closed this revision.Jan 6 2014, 8:32 PM

Closed by commit rP1786093c6e41 (authored by @epriestley).