Page MenuHomePhabricator

Phriction - fix a corner case on renaming a project
ClosedPublic

Authored by btrahan on Jan 3 2014, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 2:08 AM
Unknown Object (File)
Tue, Nov 19, 10:31 AM
Unknown Object (File)
Sun, Nov 10, 7:02 PM
Unknown Object (File)
Oct 22 2024, 3:53 PM
Unknown Object (File)
Oct 13 2024, 8:44 PM
Unknown Object (File)
Sep 19 2024, 12:15 PM
Unknown Object (File)
Sep 19 2024, 12:15 PM
Unknown Object (File)
Sep 19 2024, 12:15 PM

Details

Summary

if you rename a project in such a way that the old slug and the new slug are the same, there are errors when the phriction document is updated. detect this case and don't bother updating the document since there is no change. Fixes Github issue 474.

Test Plan

made a project "testTest". Viewed the wiki page. Created the wiki page. Renamed the project "TestTest". Before patch, this error'd, post patch it works!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

You might need to nuke src/.phutil_module_cache for lint, I think you're probably hitting T1486 (or I messed up D7880).