Page MenuHomePhabricator

Phriction - fix a corner case on renaming a project
ClosedPublic

Authored by btrahan on Jan 3 2014, 9:48 PM.
Tags
None
Referenced Files
F18752011: D7888.id.diff
Sat, Oct 4, 1:41 PM
F18745931: D7888.diff
Fri, Oct 3, 10:24 AM
F18630652: D7888.diff
Sep 16 2025, 12:20 PM
F18418604: D7888.id.diff
Aug 30 2025, 1:26 PM
F18394522: D7888.diff
Aug 29 2025, 10:03 AM
F18089214: D7888.id17847.diff
Aug 6 2025, 10:45 AM
F17946572: D7888.id17864.diff
Jul 31 2025, 2:42 PM
F17927671: D7888.id.diff
Jul 30 2025, 2:59 PM

Details

Summary

if you rename a project in such a way that the old slug and the new slug are the same, there are errors when the phriction document is updated. detect this case and don't bother updating the document since there is no change. Fixes Github issue 474.

Test Plan

made a project "testTest". Viewed the wiki page. Created the wiki page. Renamed the project "TestTest". Before patch, this error'd, post patch it works!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

You might need to nuke src/.phutil_module_cache for lint, I think you're probably hitting T1486 (or I messed up D7880).