Page MenuHomePhabricator

Move build-time resources to "CelerityPhysicalResources" to fix Phame
ClosedPublic

Authored by epriestley on Jan 1 2014, 2:51 AM.
Tags
None
Referenced Files
F13103613: D7873.diff
Sat, Apr 27, 11:12 AM
Unknown Object (File)
Wed, Apr 24, 4:31 AM
Unknown Object (File)
Mon, Apr 22, 10:36 PM
Unknown Object (File)
Thu, Apr 11, 7:30 AM
Unknown Object (File)
Sat, Apr 6, 12:08 PM
Unknown Object (File)
Mar 24 2024, 10:20 PM
Unknown Object (File)
Mar 10 2024, 6:55 AM
Unknown Object (File)
Feb 9 2024, 1:51 PM
Subscribers

Details

Summary

Ref T4222. This fixes some issues with Phame's resource construction.

Phame requires a fully virtual resource source, and since I want to run wordpress templates unmodified some day I don't want to build resource maps for skins.

Move all the stuff that depends on resource lists being discoverable at build time to CelerityPhysicalResources, and only generate maps for subclasses.

The root CelerityResources can now construct virtual resources; construct a virtual resource for Phame and use it.

Test Plan

Off-domain blogs work correctly now. On-domain blogs with custom skins work correctly now.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 1 2014, 2:54 AM
  • Remove redundant method.

Can't really test Phame's custom skins as I don't have any set up, but the code looks fine.