Page MenuHomePhabricator

Drive all Celerity operations from the new map
ClosedPublic

Authored by epriestley on Jan 1 2014, 1:21 AM.
Tags
None
Referenced Files
F14076715: D7872.diff
Thu, Nov 21, 7:27 PM
Unknown Object (File)
Wed, Nov 20, 12:26 PM
Unknown Object (File)
Tue, Nov 19, 12:26 AM
Unknown Object (File)
Mon, Nov 18, 7:41 PM
Unknown Object (File)
Mon, Nov 18, 6:45 AM
Unknown Object (File)
Fri, Nov 15, 9:49 PM
Unknown Object (File)
Mon, Nov 11, 6:07 PM
Unknown Object (File)
Fri, Nov 8, 11:13 AM
Subscribers

Details

Summary

Ref T4222.

  • Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map.
  • The new map is about 50% smaller and organized more sensibly.
  • This removes the /pkg/ URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name.
  • Removes some junky old APIs.
  • Cleans up some other APIs.
  • Added some feedback for bin/celerity map.
  • CelerityResourceMap is still a singleton which is inextricably bound to the Phabricator map; this will change in the future.
Test Plan
  • Reloaded pages.
  • Verified packaging works by looking at generated includes.
  • Forced minification on and verified it worked.
  • Forced no-timestamps on and verified it worked.
  • Rebuilt map.
  • Ran old script and verified error message.
  • Checked logs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Also:

  • Grepped for affected paths/names.
  • Used profiler to verify runtime construction of the reverse maps isn't costly (600us).

Ran new mapper and refreshed some pages and they appeared correctly.