Page MenuHomePhabricator

Drive all Celerity operations from the new map
ClosedPublic

Authored by epriestley on Jan 1 2014, 1:21 AM.
Tags
None
Referenced Files
F18673978: D7872.id17802.diff
Thu, Sep 25, 12:47 PM
F18651369: D7872.id17810.diff
Sep 21 2025, 4:08 AM
F18628961: D7872.id.diff
Sep 16 2025, 7:42 AM
F18609936: D7872.id.diff
Sep 14 2025, 3:59 AM
F18601113: D7872.diff
Sep 13 2025, 11:32 AM
F18557070: D7872.id.diff
Sep 8 2025, 7:50 PM
F18513072: D7872.diff
Sep 5 2025, 9:07 AM
F18083926: D7872.id17810.diff
Aug 5 2025, 12:27 PM
Subscribers

Details

Summary

Ref T4222.

  • Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map.
  • The new map is about 50% smaller and organized more sensibly.
  • This removes the /pkg/ URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name.
  • Removes some junky old APIs.
  • Cleans up some other APIs.
  • Added some feedback for bin/celerity map.
  • CelerityResourceMap is still a singleton which is inextricably bound to the Phabricator map; this will change in the future.
Test Plan
  • Reloaded pages.
  • Verified packaging works by looking at generated includes.
  • Forced minification on and verified it worked.
  • Forced no-timestamps on and verified it worked.
  • Rebuilt map.
  • Ran old script and verified error message.
  • Checked logs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Also:

  • Grepped for affected paths/names.
  • Used profiler to verify runtime construction of the reverse maps isn't costly (600us).

Ran new mapper and refreshed some pages and they appeared correctly.