Page MenuHomePhabricator

Drive all Celerity operations from the new map
ClosedPublic

Authored by epriestley on Jan 1 2014, 1:21 AM.
Tags
None
Referenced Files
F15484302: D7872.id17802.diff
Wed, Apr 9, 5:31 PM
F15483354: D7872.id17810.diff
Wed, Apr 9, 11:55 AM
F15462223: D7872.id17810.diff
Tue, Apr 1, 1:11 PM
F15461088: D7872.id.diff
Tue, Apr 1, 5:07 AM
F15459502: D7872.diff
Mon, Mar 31, 1:36 PM
F15402610: D7872.id17810.diff
Mar 17 2025, 11:17 PM
F15386039: D7872.diff
Mar 14 2025, 11:55 PM
F15381339: D7872.id17802.diff
Mar 14 2025, 7:08 AM
Subscribers

Details

Summary

Ref T4222.

  • Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map.
  • The new map is about 50% smaller and organized more sensibly.
  • This removes the /pkg/ URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name.
  • Removes some junky old APIs.
  • Cleans up some other APIs.
  • Added some feedback for bin/celerity map.
  • CelerityResourceMap is still a singleton which is inextricably bound to the Phabricator map; this will change in the future.
Test Plan
  • Reloaded pages.
  • Verified packaging works by looking at generated includes.
  • Forced minification on and verified it worked.
  • Forced no-timestamps on and verified it worked.
  • Rebuilt map.
  • Ran old script and verified error message.
  • Checked logs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Also:

  • Grepped for affected paths/names.
  • Used profiler to verify runtime construction of the reverse maps isn't costly (600us).

Ran new mapper and refreshed some pages and they appeared correctly.