Page MenuHomePhabricator

Drive all Celerity operations from the new map
ClosedPublic

Authored by epriestley on Jan 1 2014, 1:21 AM.
Tags
None
Referenced Files
F19831800: D7872.id17810.diff
Mar 10 2026, 8:49 PM
F19831799: D7872.id17810.diff
Mar 10 2026, 8:44 PM
F19814727: D7872.diff
Mar 4 2026, 3:21 PM
F19757752: D7872.diff
Feb 17 2026, 8:00 PM
F19757751: D7872.diff
Feb 17 2026, 8:00 PM
F19616762: D7872.diff
Feb 4 2026, 3:20 AM
F19511828: D7872.id17802.diff
Jan 12 2026, 8:19 AM
F19436107: D7872.diff
Dec 28 2025, 3:15 PM
Subscribers

Details

Summary

Ref T4222.

  • Removes the old map and changes the CelerityResourceMap API to be entirely driven by the new map.
  • The new map is about 50% smaller and organized more sensibly.
  • This removes the /pkg/ URI component. All resources are now required to have unique names, so we can tell if a resource is a package or not by looking at the name.
  • Removes some junky old APIs.
  • Cleans up some other APIs.
  • Added some feedback for bin/celerity map.
  • CelerityResourceMap is still a singleton which is inextricably bound to the Phabricator map; this will change in the future.
Test Plan
  • Reloaded pages.
  • Verified packaging works by looking at generated includes.
  • Forced minification on and verified it worked.
  • Forced no-timestamps on and verified it worked.
  • Rebuilt map.
  • Ran old script and verified error message.
  • Checked logs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Also:

  • Grepped for affected paths/names.
  • Used profiler to verify runtime construction of the reverse maps isn't costly (600us).

Ran new mapper and refreshed some pages and they appeared correctly.