Page MenuHomePhabricator
Differential D7859

Add a Diffusion repository remarkup rule
ClosedPublic
Actions

Authored by epriestley on Dec 30 2013, 10:54 PM.
Tags
None
Referenced Files
F13439942: D7859.diff
Fri, Jul 12, 4:52 AM
F13423296: D7859.id.diff
Tue, Jul 9, 12:19 AM
F13418430: D7859.diff
Mon, Jul 8, 1:04 AM
F13412472: D7859.id17774.diff
Sun, Jul 7, 1:52 AM
F13411719: D7859.id17782.diff
Sat, Jul 6, 9:37 PM
F13410606: D7859.id.diff
Sat, Jul 6, 4:14 PM
F13401152: D7859.diff
Thu, Jul 4, 12:54 PM
F13382864: D7859.diff
Sun, Jun 30, 8:17 AM
View All Files
Subscribers
aran
poop

Details

Reviewers
btrahan
dctrwatson
Commits
Restricted Diffusion Commit
rPc20fd5830374: Add a Diffusion repository remarkup rule
Summary

Currently we markup rXabcd, but not rX on its own. Mark these up as repository object names.

Test Plan

Typed rPOEMS, rPOEMS1, rPOEMS139893189, etc.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Dec 31 2013, 12:43 AM
  • Also fix (probably) an issue with rXnnnn rules and users who can't see Diffusion.
epriestley added a subscriber: poop.Dec 31 2013, 12:43 AM

@poop, the last update probably fixes your issue.

poop added a comment.Dec 31 2013, 12:47 AM

Yep, it does.

btrahan accepted this revision.Dec 31 2013, 6:13 PM
epriestley closed this revision.Dec 31 2013, 7:08 PM

Closed by commit rPc20fd5830374 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
6 lines
applications/
diffusion/
application/
3 lines
query/
4 lines
remarkup/
DiffusionCommitRemarkupRule.php
DiffusionRemarkupRule.php
2 lines
25 lines

Diff 17789

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorApplicationDiffusion.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
View Options

src/applications/diffusion/remarkup/DiffusionCommitRemarkupRule.php

Loading...
View Options

src/applications/diffusion/remarkup/DiffusionRemarkupRule.php

Loading...
View Options

src/applications/diffusion/remarkup/DiffusionRepositoryRemarkupRule.php

Loading...
Phabricator · Built by Phacility