Differential D7840
Make all bin/* scripts locate their workflows dynamically Authored by epriestley on Dec 26 2013, 9:50 PM. Tags None Referenced Files
Subscribers
Details
Ref T2015. Not directly related to Drydock, but I bumped into this. All these scripts currently enumerate their workflows explicitly. Instead, use PhutilSymbolLoader to automatically discover workflows. This reduces code duplication and errors (see all the bad extends this diff fixes) and lets third parties add new workflows (not clearly valuable?). Ran bin/x help for each modified script.
Diff Detail
Event TimelineComment Actions I can't imagine 3rd party scripts being made too often; basically everything they could need is already there, and if it isn't they are more likely to just ask than build something... Comment Actions Yeah, I don't have any real use cases in mind for that. I could maybe imagine something like a third-party file storage engine adding some commands to bin/files or something, but that's quite a stretch. |