Page MenuHomePhabricator

Extend all "ManagementWorkflow" classes from a base class
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 10:19 AM
Unknown Object (File)
Feb 15 2024, 1:15 PM
Unknown Object (File)
Jan 22 2024, 7:55 PM
Unknown Object (File)
Dec 5 2023, 1:42 PM
Unknown Object (File)
Dec 2 2023, 3:32 PM
Unknown Object (File)
Nov 23 2023, 8:13 PM
Unknown Object (File)
Nov 23 2023, 11:47 AM
Unknown Object (File)
Nov 12 2023, 1:01 PM
Subscribers

Details

Summary

Ref T2015. Not directly related to Drydock, but I've wanted to do this for a bit.

Introduce a common base class for all the workflows in the scripts in bin/*. This slightly reduces code duplication by moving isExecutable() to the base, but also provides getViewer(). This is a little nicer than PhabricatorUser::getOmnipotentUser() and gives us a layer of indirection if we ever want to introduce more general viewer mechanisms in scripts.

Test Plan

Lint; ran some of the scripts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped