Page MenuHomePhabricator

Extend all "ManagementWorkflow" classes from a base class
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 8, 12:51 AM
Unknown Object (File)
Sat, Jun 7, 5:02 AM
Unknown Object (File)
Fri, Jun 6, 11:20 AM
Unknown Object (File)
May 7 2025, 12:24 AM
Unknown Object (File)
May 6 2025, 5:02 AM
Unknown Object (File)
May 5 2025, 11:23 AM
Unknown Object (File)
Apr 29 2025, 11:41 PM
Unknown Object (File)
Mar 26 2025, 11:15 AM
Subscribers

Details

Summary

Ref T2015. Not directly related to Drydock, but I've wanted to do this for a bit.

Introduce a common base class for all the workflows in the scripts in bin/*. This slightly reduces code duplication by moving isExecutable() to the base, but also provides getViewer(). This is a little nicer than PhabricatorUser::getOmnipotentUser() and gives us a layer of indirection if we ever want to introduce more general viewer mechanisms in scripts.

Test Plan

Lint; ran some of the scripts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped