Page MenuHomePhabricator

Extend all "ManagementWorkflow" classes from a base class
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:39 PM.
Tags
None
Referenced Files
F19054129: D7838.diff
Nov 28 2025, 10:47 AM
F18847403: D7838.id.diff
Oct 30 2025, 12:27 AM
F18847180: D7838.diff
Oct 29 2025, 11:13 PM
F18841726: D7838.diff
Oct 28 2025, 10:45 AM
F18784653: D7838.id.diff
Oct 13 2025, 2:02 PM
F18735886: D7838.diff
Oct 1 2025, 3:51 AM
F18709698: D7838.id.diff
Sep 29 2025, 12:32 AM
F18698218: D7838.diff
Sep 27 2025, 10:59 AM
Subscribers

Details

Summary

Ref T2015. Not directly related to Drydock, but I've wanted to do this for a bit.

Introduce a common base class for all the workflows in the scripts in bin/*. This slightly reduces code duplication by moving isExecutable() to the base, but also provides getViewer(). This is a little nicer than PhabricatorUser::getOmnipotentUser() and gives us a layer of indirection if we ever want to introduce more general viewer mechanisms in scripts.

Test Plan

Lint; ran some of the scripts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped