Page MenuHomePhabricator

Extend all "ManagementWorkflow" classes from a base class
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 6:32 AM
Unknown Object (File)
Tue, Jan 21, 9:11 AM
Unknown Object (File)
Jan 2 2025, 1:12 AM
Unknown Object (File)
Jan 1 2025, 5:10 AM
Unknown Object (File)
Dec 30 2024, 11:49 AM
Unknown Object (File)
Dec 21 2024, 9:46 AM
Unknown Object (File)
Dec 21 2024, 6:56 AM
Unknown Object (File)
Dec 17 2024, 7:50 PM
Subscribers

Details

Summary

Ref T2015. Not directly related to Drydock, but I've wanted to do this for a bit.

Introduce a common base class for all the workflows in the scripts in bin/*. This slightly reduces code duplication by moving isExecutable() to the base, but also provides getViewer(). This is a little nicer than PhabricatorUser::getOmnipotentUser() and gives us a layer of indirection if we ever want to introduce more general viewer mechanisms in scripts.

Test Plan

Lint; ran some of the scripts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped