Page MenuHomePhabricator

Extend all "ManagementWorkflow" classes from a base class
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:39 PM.
Tags
None
Referenced Files
F18784653: D7838.id.diff
Mon, Oct 13, 2:02 PM
F18735886: D7838.diff
Wed, Oct 1, 3:51 AM
F18709698: D7838.id.diff
Mon, Sep 29, 12:32 AM
F18698218: D7838.diff
Sat, Sep 27, 10:59 AM
F18112945: D7838.id17731.diff
Aug 12 2025, 10:08 PM
F18112593: D7838.id17750.diff
Aug 12 2025, 6:58 PM
F18111732: D7838.diff
Aug 12 2025, 11:49 AM
F17644054: D7838.diff
Jul 11 2025, 10:12 PM
Subscribers

Details

Summary

Ref T2015. Not directly related to Drydock, but I've wanted to do this for a bit.

Introduce a common base class for all the workflows in the scripts in bin/*. This slightly reduces code duplication by moving isExecutable() to the base, but also provides getViewer(). This is a little nicer than PhabricatorUser::getOmnipotentUser() and gives us a layer of indirection if we ever want to introduce more general viewer mechanisms in scripts.

Test Plan

Lint; ran some of the scripts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped