Page MenuHomePhabricator

Extend all "ManagementWorkflow" classes from a base class
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:39 PM.
Tags
None
Referenced Files
F15440148: D7838.diff
Wed, Mar 26, 11:15 AM
F15434060: D7838.id.diff
Tue, Mar 25, 1:45 AM
F15431392: D7838.id17750.diff
Mon, Mar 24, 12:05 PM
F15408265: D7838.diff
Tue, Mar 18, 10:00 PM
F15397220: D7838.id.diff
Sun, Mar 16, 6:54 PM
F15337388: D7838.diff
Mar 9 2025, 5:38 AM
Unknown Object (File)
Feb 24 2025, 11:21 AM
Unknown Object (File)
Feb 24 2025, 12:55 AM
Subscribers

Details

Summary

Ref T2015. Not directly related to Drydock, but I've wanted to do this for a bit.

Introduce a common base class for all the workflows in the scripts in bin/*. This slightly reduces code duplication by moving isExecutable() to the base, but also provides getViewer(). This is a little nicer than PhabricatorUser::getOmnipotentUser() and gives us a layer of indirection if we ever want to introduce more general viewer mechanisms in scripts.

Test Plan

Lint; ran some of the scripts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped